Skip to content

docs: roadmap — empirical findings from PR #18 attempt#19

Merged
membphis merged 1 commit into
mainfrom
docs/roadmap-validate-brackets-empirical
May 16, 2026
Merged

docs: roadmap — empirical findings from PR #18 attempt#19
membphis merged 1 commit into
mainfrom
docs/roadmap-validate-brackets-empirical

Conversation

@membphis
Copy link
Copy Markdown
Collaborator

Summary

Updates the `validate_brackets` fusion roadmap entry to reflect what we learned from attempting it in #18.

Before

The entry said "<1% effect on string-heavy workloads; worth revisiting only if profiling on structurally-dense input flags it" — accurate but didn't capture WHY a prototype attempt would have shown no gain.

After

  • Links to perf(scan): fuse validate_brackets into SIMD emit loops #18 (closed) for the working prototype
  • Names the specific mechanism that canceled the win: per-emit `buf[pos]` lookup in `emit_bits_validate` adds roughly what the eliminated `validate_brackets` walk saved on sparse-structural input
  • Pins the revisit condition to a concrete prerequisite: a structurally-dense bench fixture being added to the harness

Doc-only change. Keeps the roadmap actionable for future contributors.

Test plan

  • `grep validate_brackets README.md` shows the updated entry
  • CI doc-only path (no Rust changes, expect green)

The validate_brackets fusion entry now references the closed PR #18,
explains why the prototype showed no measurable improvement on the
string-heavy multimodal bench (per-emit buf[pos] lookup cancels the
savings from eliminating the second indices pass), and pins the
revisit condition to a structurally-dense bench fixture appearing.

Keeps the entry actionable: future contributors know the design has
been tried, what failed, and what data to gather before retrying.
@membphis membphis merged commit a4fc583 into main May 16, 2026
1 check passed
@membphis membphis deleted the docs/roadmap-validate-brackets-empirical branch May 16, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant