Draft
Conversation
- Add `LoggerOutputs` interface and `setOutputs`/`reset` methods to `Logger` - Add `NoopLoggerOutput` for silent test runs when `APIFY_NO_LOGS_IN_TESTS` is set - Update `useConsoleSpy` to install a capturing `LoggerOutput` directly instead of wrapping raw streams
Prevents Vitest's noop-logger flag from leaking into the spawned CLI process, so e2e tests can assert on real stdout/stderr output.
Contributor
|
I think that the second option is better. Just a side note -> have you ever seen/used CLI that use different language than English? Or we will use English, and this is just better code convention to do it? |
Member
Author
|
I've seen Claude has several languages if I recall. I personally don't use anything but English but ik others might want it. That said I mostly wanted to have a structured way to define messages, maybe I can refactor it to drop locales and just have a way to define the 3 variants for messages (human, markdown and json) |
Contributor
|
Do you think that we need difference for human vs markdown? Should not we have everything in md as it is quite easy format to read? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far this PR tackles a nicer logger interface than random imported functions across the project, and also lays the ground work for i18n support (both in formatting strings, using the ICU Message format).
I am ready to port all messages and write upgrades to CLAUDE.md and such, but I want to know where we want to store these localized messages
src/i18nand import where needed