ci: install Apify CLI with pnpm in scheduled e2e tests#1874
Merged
Conversation
`npm install -g apify-cli` started failing in the scheduled E2E tests because the package now ships a `preinstall` hook (`npx only-allow pnpm`) to refuse non-pnpm installs. On the GitHub runners the hook exits 127 (`sh: 1: only-allow: not found`) before any test runs, so every matrix job fails at the install step (e.g. run 25421420663). Set up pnpm via `pnpm/action-setup` and install `apify-cli` globally with `pnpm add -g`, mirroring the pnpm-based approach already used in the docs workflows (#1871). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
t-tooling
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1874 +/- ##
==========================================
- Coverage 92.57% 92.56% -0.01%
==========================================
Files 158 158
Lines 11078 11078
==========================================
- Hits 10255 10254 -1
- Misses 823 824 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
We need to fix this in the CLI, we can't enforce pnpm downstream, that would be a pretty crazy move for an OSS project. |
Member
|
On the other hand, we should use pnpm here, so let's merge this if it helps. Just saying that this happening is a bug in the CLI on its own. |
Collaborator
Collaborator
Author
|
@janbuchar please recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The scheduled E2E tests workflow has been failing on every matrix job at the Install dependencies step (latest example: run 25421420663).
npm install -g apify-clinow fails because the publishedapify-clipackage ships apreinstallhook (npx only-allow pnpm) that refuses non-pnpm installs. On the GitHub runners that hook can't auto-fetchonly-allowand exits before any test runs:Changes
Setup pnpmstep usingpnpm/action-setup@v4.apify-cliglobally viapnpm add -g apify-cliinstead ofnpm install -g.This mirrors the pnpm-based approach already adopted by the docs workflows in #1871.
🤖 Generated with Claude Code