Skip to content

ci: fix better-sqlite3 version#3604

Open
l2ysho wants to merge 3 commits intomasterfrom
fix-better-sqlite3
Open

ci: fix better-sqlite3 version#3604
l2ysho wants to merge 3 commits intomasterfrom
fix-better-sqlite3

Conversation

@l2ysho
Copy link
Copy Markdown
Contributor

@l2ysho l2ysho commented Apr 24, 2026

No description provided.

@l2ysho l2ysho requested review from barjin and vladfrangu April 24, 2026 13:11
@l2ysho l2ysho self-assigned this Apr 24, 2026
@l2ysho l2ysho added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Apr 24, 2026
@github-actions github-actions Bot added this to the 139th sprint - Tooling team milestone Apr 24, 2026
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label Apr 24, 2026
Copy link
Copy Markdown
Member

@barjin barjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that more of the E2E tests have failed (below is grep "fatal" of the failing CI job).

Image

Fwiw all of them seem to have issues with the better-sqlite installation

@l2ysho
Copy link
Copy Markdown
Contributor Author

l2ysho commented Apr 24, 2026

It seems that more of the E2E tests have failed (below is grep "fatal" of the failing CI job).

Image Fwiw all of them seem to have issues with the `better-sqlite` installation

Lets wait for https://github.com/apify/crawlee/actions/runs/24891314970

@l2ysho
Copy link
Copy Markdown
Contributor Author

l2ysho commented Apr 24, 2026

@patrikbraborec @DaveHanns tagging you so you are in the loop. This PR resolve (I hope) e2e tests problem in crawlee where we use CLI beta. https://github.com/apify/crawlee/actions/workflows/test-e2e.yml

@B4nan
Copy link
Copy Markdown
Member

B4nan commented Apr 24, 2026

all e2e tests are using the local storage, i dont think this is enough to fix the e2e tests

@l2ysho
Copy link
Copy Markdown
Contributor Author

l2ysho commented Apr 24, 2026

all e2e tests are using the local storage, i dont think this is enough to fix the e2e tests

yop, it failed right now.

Copy link
Copy Markdown
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should have fixed it in the module but sure if it works

@l2ysho
Copy link
Copy Markdown
Contributor Author

l2ysho commented Apr 24, 2026

I feel like we should have fixed it in the module but sure if it works

seems https://github.com/apify/apify-storage-local-js was updated ~5 month ago, we just missing release. Locally it is working with "@apify/storage-local": "^2.3.1-beta.1"

I will try it in this PR with this version just to check e2e tests before CLI release.

@B4nan
Copy link
Copy Markdown
Member

B4nan commented Apr 24, 2026

Yeah, we bumped it some time ago, but I am not sure if we want to ship a new version, this is breaking, so it would have to be a major bump, and I would prefer to reserve that for the v4 rewrite (especially since nobody asked for this).

edit: on the other hand, its on v2, so if we ship v3 with the deps update, we would align the next major with crawlee...

@l2ysho
Copy link
Copy Markdown
Contributor Author

l2ysho commented Apr 24, 2026

Yeah, I bumped it some time ago, but I am not sure if we want to ship a new version, this is breaking, so it would have to be a major bump, and I would prefer to reserve that for the v4 rewrite (especially since nobody asked for this).

Well yes, but now @apify/storage-local works only with node@20 which is not maintained

@B4nan
Copy link
Copy Markdown
Member

B4nan commented Apr 24, 2026

Hmm, good point, we can ship that, especially given what I said above.

But let's bump other deps too, not just this one. I am sure there will be more things with a major bump.

@l2ysho
Copy link
Copy Markdown
Contributor Author

l2ysho commented Apr 24, 2026

I am sure there will be more things with a major bump.

There are some, I can do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants