Conversation
Lets wait for https://github.com/apify/crawlee/actions/runs/24891314970 |
|
@patrikbraborec @DaveHanns tagging you so you are in the loop. This PR resolve (I hope) e2e tests problem in crawlee where we use CLI beta. https://github.com/apify/crawlee/actions/workflows/test-e2e.yml |
|
all e2e tests are using the local storage, i dont think this is enough to fix the e2e tests |
yop, it failed right now. |
vladfrangu
left a comment
There was a problem hiding this comment.
I feel like we should have fixed it in the module but sure if it works
seems https://github.com/apify/apify-storage-local-js was updated ~5 month ago, we just missing release. Locally it is working with I will try it in this PR with this version just to check e2e tests before CLI release. |
|
Yeah, we bumped it some time ago, but I am not sure if we want to ship a new version, this is breaking, so it would have to be a major bump, and I would prefer to reserve that for the v4 rewrite (especially since nobody asked for this). edit: on the other hand, its on v2, so if we ship v3 with the deps update, we would align the next major with crawlee... |
Well yes, but now |
|
Hmm, good point, we can ship that, especially given what I said above. But let's bump other deps too, not just this one. I am sure there will be more things with a major bump. |
There are some, I can do it. |


No description provided.