Skip to content

fix(ci): exclude impit-* from minimumReleaseAge in release workflow#438

Merged
barjin merged 2 commits intomasterfrom
fix/release-lockfile-min-age
Apr 27, 2026
Merged

fix(ci): exclude impit-* from minimumReleaseAge in release workflow#438
barjin merged 2 commits intomasterfrom
fix/release-lockfile-min-age

Conversation

@barjin
Copy link
Copy Markdown
Member

@barjin barjin commented Apr 27, 2026

The release workflow publishes platform binaries, then immediately runs pnpm install --lockfile-only to refresh the lockfile.

With minimumReleaseAge set to 1440, the just-published impit-* packages cannot be locked, so the old version's optionalDependencies entries are removed without the new ones being added - leaving master with a stale lockfile that breaks subsequent --frozen-lockfile installs in PR CI.

The release workflow publishes platform binaries then immediately runs
pnpm install --lockfile-only to refresh the lockfile. With minimumReleaseAge
set to 1440, the just-published impit-* packages cannot be locked, so the
old version's optionalDependencies entries are removed without the new
ones being added — leaving master with a stale lockfile that breaks
subsequent --frozen-lockfile installs in PR CI.
@github-actions github-actions Bot added this to the 139th sprint - Tooling team milestone Apr 27, 2026
@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Apr 27, 2026
@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Apr 27, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the impit-node PNPM configuration to prevent freshly published impit-* platform packages from being blocked by minimumReleaseAge during the release workflow’s post-publish lockfile refresh, avoiding stale/broken lockfiles that can later fail --frozen-lockfile installs in CI.

Changes:

  • Add impit-* to minimumReleaseAgeExclude so newly published platform packages can be resolved immediately during pnpm install --lockfile-only.
  • Update pnpm-lock.yaml to retain the impit-* optional dependency entries at 0.13.1.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
impit-node/pnpm-workspace.yaml Excludes impit-* from minimumReleaseAge gating so release-time lockfile updates can resolve just-published binaries.
impit-node/pnpm-lock.yaml Regenerates lockfile to include/retain impit-* optionalDependencies and package/snapshot entries.
Files not reviewed (1)
  • impit-node/pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@barjin barjin requested a review from B4nan April 27, 2026 05:46
@barjin barjin merged commit c4255bc into master Apr 27, 2026
38 checks passed
@barjin barjin deleted the fix/release-lockfile-min-age branch April 27, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants