fix(node): harden vanillaFallback compatibility fallback for native transport bootstrap failures#440
Draft
jippylong12 wants to merge 1 commit intoapify:masterfrom
Draft
Conversation
a384b70 to
ba60b8b
Compare
ba60b8b to
bebf8f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the Node wrapper's
vanillaFallbackbehavior for a narrow class of native transport bootstrap failures.Important: this PR does not fix the underlying native browser-mode transport incompatibility. It adds a safer wrapper-level recovery path when the native transport fails before a usable response is received.
Refs #439
Related: #205
What this PR is
vanillaFallbackWhat this PR is not
Problem
The native browser-mode transport can fail immediately against a legacy HTTPS target during initial request bootstrap.
A first wrapper fallback patch proved the compatibility idea, but it was too broad and had correctness issues around retries, cookies, abort handling, and fallback boundaries.
Changes
Structural cleanup
impit-node/vanilla-fallback.jsimpit-node/test/vanilla-fallback.helpers.tsSafer retry scope
Correctness fixes
Set-Cookiezstdfrom the compatibility transportAbort and cleanup
Fallback boundaries
Validation
Ran:
pnpm exec vitest run test/basics.test.tsResult:
276 passed | 3 skippedAdded / updated coverage for:
Also manually rechecked the target behavior:
GETsucceeded through the compatibility pathPOSTsucceeded through the compatibility pathFollow-up
The native transport incompatibility should still be tracked and fixed separately.