fix: resolve golangci-lint errors across codebase

internal/handler/templates.go

@@ -276,7 +276,7 @@ func InstallTemplate() http.HandlerFunc {
 		// Helper to send SSE events
 		sendSSE := func(event InstallProgressEvent) {
 			data, _ := json.Marshal(event)
-			fmt.Fprintf(w, "data: %s\n\n", data)
+			_, _ = fmt.Fprintf(w, "data: %s\n\n", data)
 			flusher.Flush()
 		}
 

pkg/codegen/filters/filterjava/java_async_return.go

@@ -54,7 +54,6 @@ func ToAsyncReturnString(prefix string, schema *objmodel.Schema) (string, error)
 		text = fmt.Sprintf("%s%s", prefix, common.CamelTitleCase(s_imported.Name))
 	case objmodel.TypeExtern:
 		xe := parseJavaExtern(schema)
-		text = fmt.Sprintf("new %s()", xe.Name)
 		var java_module string
 		java_module = ""
 		if xe.Package != "" {

pkg/codegen/filters/filterjava/java_default.go

@@ -117,7 +117,6 @@ func ToDefaultString(schema *objmodel.Schema, prefix string) (string, error) {
 			text = fmt.Sprintf("new %s%s()", prefix, s_imported.Name)
 		case objmodel.TypeExtern:
 			xe := parseJavaExtern(schema)
-			text = fmt.Sprintf("new %s()", xe.Name)
 			if xe.Default != "" {
 				text = xe.Default
 			} else {
@@ -135,9 +134,6 @@ func ToDefaultString(schema *objmodel.Schema, prefix string) (string, error) {
 				return "xxx", fmt.Errorf("javaDefault interface not found: %s", schema.Dump())
 			}
 			// if interface is local it is found both as s_local and s_imported
-			if i_local == nil {
-				prefix = fmt.Sprintf("%s.%s_impl.", common.CamelLowerCase(i_imported.Module.Name), common.CamelLowerCase(i_imported.Module.Name))
-			}
 			text = "null"
 		default:
 			return "xxx", fmt.Errorf("javaDefault unknown schema %s", schema.Dump())

pkg/codegen/filters/filterjava/java_element_type.go

@@ -30,8 +30,6 @@ func ToElementTypeString(prefix string, schema *objmodel.Schema) (string, error)
 	case objmodel.TypeBool:
 		text = "boolean"
 	case objmodel.TypeEnum:
-		symbol := schema.GetEnum()
-		text = fmt.Sprintf("%s%s", prefix, symbol.Name)
 		e_local := schema.LookupEnum("", schema.Type)
 		e_imported := schema.LookupEnum(schema.Import, schema.Type)
 		if e_local == nil && e_imported == nil {
@@ -56,7 +54,6 @@ func ToElementTypeString(prefix string, schema *objmodel.Schema) (string, error)
 		text = fmt.Sprintf("%s%s", prefix, common.CamelTitleCase(s_imported.Name))
 	case objmodel.TypeExtern:
 		xe := parseJavaExtern(schema)
-		text = fmt.Sprintf("new %s()", xe.Name)
 		var java_module string
 		java_module = ""
 		if xe.Package != "" {

pkg/codegen/filters/filterjava/java_return.go

@@ -54,7 +54,6 @@ func ToReturnString(prefix string, schema *objmodel.Schema) (string, error) {
 		text = fmt.Sprintf("%s%s", prefix, common.CamelTitleCase(s_imported.Name))
 	case objmodel.TypeExtern:
 		xe := parseJavaExtern(schema)
-		text = fmt.Sprintf("new %s()", xe.Name)
 		var java_module string
 		java_module = ""
 		if xe.Package != "" {

pkg/codegen/filters/filterjava/java_test_value.go

@@ -58,7 +58,6 @@ func ToTestValueString(prefix string, schema *objmodel.Schema) (string, error) {
 		text = fmt.Sprintf("new %s%s()", prefix, s_imported.Name)
 	case objmodel.TypeExtern:
 		xe := parseJavaExtern(schema)
-		text = fmt.Sprintf("new %s()", xe.Name)
 		if xe.Default != "" {
 			text = xe.Default
 		} else {

pkg/codegen/filters/filterjni/jni_java_signature_param.go

@@ -57,10 +57,8 @@ func jniSignatureType(node *objmodel.TypedNode) (string, error) {
 		}
 	case objmodel.TypeExtern:
 		xe := filterjava.MakeJavaExtern(&node.Schema)
-		var java_module string
-		java_module = ""
 		if xe.Package != "" {
-			java_module = xe.Package
+			java_module := xe.Package
 			java_module = common.Replace(java_module, ".", "/")
 			text = "L" + java_module + "/" + xe.Name + ";"
 		} else {
@@ -69,8 +67,7 @@ func jniSignatureType(node *objmodel.TypedNode) (string, error) {
 	case objmodel.TypeInterface:
 		i := node.LookupInterface(node.Import, node.Type)
 		if i != nil {
-			var name string
-			name = "I" + i.Name
+			name := "I" + i.Name
 			text = makeFullTypeName(i.Module.Name, name)
 		} else {
 			return "xxx", fmt.Errorf("ToSignatureType interface not found %s", node.Dump())

pkg/foundation/config/config_test.go

@@ -76,8 +76,8 @@ func TestNewConfig(t *testing.T) {
 		dir := t.TempDir()
 		customCacheDir := filepath.Join(dir, "custom-cache")
 
-		os.Setenv("APIGEAR_CACHE_DIR", customCacheDir)
-		defer os.Unsetenv("APIGEAR_CACHE_DIR")
+		_ = os.Setenv("APIGEAR_CACHE_DIR", customCacheDir)
+		defer func() { _ = os.Unsetenv("APIGEAR_CACHE_DIR") }()
 
 		cfg, err := NewConfig(dir)
 		require.NoError(t, err)
@@ -90,8 +90,8 @@ func TestNewConfig(t *testing.T) {
 		dir := t.TempDir()
 		customRegistryDir := filepath.Join(dir, "custom-registry")
 
-		os.Setenv("APIGEAR_REGISTRY_DIR", customRegistryDir)
-		defer os.Unsetenv("APIGEAR_REGISTRY_DIR")
+		_ = os.Setenv("APIGEAR_REGISTRY_DIR", customRegistryDir)
+		defer func() { _ = os.Unsetenv("APIGEAR_REGISTRY_DIR") }()
 
 		cfg, err := NewConfig(dir)
 		require.NoError(t, err)

pkg/objmodel/spec/schema_test.go

@@ -257,13 +257,13 @@ func TestLoadSchema(t *testing.T) {
 
 	t.Run("panics for unknown document type", func(t *testing.T) {
 		assert.Panics(t, func() {
-			LoadSchema(DocumentTypeUnknown)
+			_, _ = LoadSchema(DocumentTypeUnknown)
 		})
 	})
 
 	t.Run("panics for invalid document type", func(t *testing.T) {
 		assert.Panics(t, func() {
-			LoadSchema(DocumentType("invalid"))
+			_, _ = LoadSchema(DocumentType("invalid"))
 		})
 	})
 }

pkg/runtime/events/stub_test.go

@@ -12,7 +12,7 @@ func TestStubEventBusImplementsInterface(t *testing.T) {
 // TestStubEventBusPublish verifies Publish is a no-op
 func TestStubEventBusPublish(t *testing.T) {
 	bus := NewStubEventBus()
-	defer bus.Close()
+	defer func() { _ = bus.Close() }()
 
 	e := NewEvent("test.event", map[string]any{"key": "value"})
 	err := bus.Publish(e)
@@ -25,7 +25,7 @@ func TestStubEventBusPublish(t *testing.T) {
 // TestStubEventBusRequest verifies Request returns an error event
 func TestStubEventBusRequest(t *testing.T) {
 	bus := NewStubEventBus()
-	defer bus.Close()
+	defer func() { _ = bus.Close() }()
 
 	e := NewEvent("test.request", map[string]any{"key": "value"})
 	resp, err := bus.Request(e)
@@ -50,7 +50,7 @@ func TestStubEventBusRequest(t *testing.T) {
 // TestStubEventBusRegister verifies Register is a no-op
 func TestStubEventBusRegister(t *testing.T) {
 	bus := NewStubEventBus()
-	defer bus.Close()
+	defer func() { _ = bus.Close() }()
 
 	called := false
 	handler := func(e *Event) (*Event, error) {
@@ -70,7 +70,7 @@ func TestStubEventBusRegister(t *testing.T) {
 // TestStubEventBusUse verifies Use is a no-op
 func TestStubEventBusUse(t *testing.T) {
 	bus := NewStubEventBus()
-	defer bus.Close()
+	defer func() { _ = bus.Close() }()
 
 	called := false
 	middleware := func(e *Event) (*Event, error) {
@@ -106,14 +106,14 @@ func TestStubEventBusClose(t *testing.T) {
 // TestStubEventBusConcurrency verifies thread safety
 func TestStubEventBusConcurrency(t *testing.T) {
 	bus := NewStubEventBus()
-	defer bus.Close()
+	defer func() { _ = bus.Close() }()
 
 	// Run operations concurrently to check for race conditions
 	done := make(chan bool, 3)
 
 	go func() {
 		for i := 0; i < 100; i++ {
-			bus.Publish(NewEvent("test", nil))
+			_ = bus.Publish(NewEvent("test", nil))
 		}
 		done <- true
 	}()