This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Apigee X: Southbound PSC to connect to internal Cloud Run services in GCP#116
Open
JoelGauci wants to merge 2 commits intoapigee:mainfrom
Open
Apigee X: Southbound PSC to connect to internal Cloud Run services in GCP#116JoelGauci wants to merge 2 commits intoapigee:mainfrom
JoelGauci wants to merge 2 commits intoapigee:mainfrom
Conversation
get the latest version
danistrebel
suggested changes
May 25, 2023
Contributor
danistrebel
left a comment
There was a problem hiding this comment.
Hi @JoelGauci thanks for this sample. I agree this pattern would definitely be a great addition.
A few changes that I'd like to propose:
- Can we please add the apigee-x-core module and to make this sample standalone with the Apigee Instance included.
- It seems like the Cloud Run Services are very similar. How about you generalize it to a single mock service and supply the path and mock body as env variable instead? That would help with the maintainability of the whole thing.
- Can we consider using the cloud foundation fabric module for Cloud Run instead of
GoogleCloudPlatform/cloud-run/google. Ideally we'd like to keep the number of independently versioned artifacts limited? - Move some hardcoded hostnames, ips and CIDRs to variables with default values?
- Export the DNS names in the outputs.tf
- Align the DNS names in the diagram with the values in the code (iloveapis vs example)
- Maybe move the DNS part to its own reusable module
Happy to have a chat and discuss all of the above points and challenge if they make sense. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this sample, the following elements are provided:
PSC southbound from Apigee X
Internal Cloud Run apps
Internal HTTPS Load Balancer with Serverless NEG based on URL Masking to target Cloud Run services
Cloud DNS
I have run all the tests locally and they all pass.
I have followed the relevant style guide for my changes.