-
Notifications
You must be signed in to change notification settings - Fork 1
Remove tracing #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove tracing #60
Conversation
WalkthroughThis pull request removes OpenTelemetry tracing support from the codebase. Changes include deletion of SpanCollector and ApitallySpanCollector classes, removal of tracing configuration options, elimination of spans and traceId from logging request objects, updates to request logging APIs, and corresponding test adjustments. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 🧪 Unit Test Generation v2 is now available!We have significantly improved our unit test generation capabilities. To enable: Add this to your reviews:
finishing_touches:
unit_tests:
enabled: trueTry it out by using the Have feedback? Share your thoughts on our Discord thread! Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
src/main/java/io/apitally/common/RequestLogger.java (1)
12-12: Remove unused import.The
SpanDataimport is no longer used after removing tracing functionality. This is likely causing the Spotless formatting check failure.🧹 Proposed fix
-import io.apitally.common.dto.SpanData;src/main/java/io/apitally/spring/ApitallyFilter.java (1)
13-13: Remove unused import.The
SpanDataimport is no longer used after removing span tracing functionality from the filter.🧹 Proposed fix
-import io.apitally.common.dto.SpanData;src/test/java/io/apitally/common/RequestLoggerTest.java (1)
14-14: Remove unused import.The
SpanDataimport is no longer used after removing tracing-related test code. This is likely contributing to the Spotless formatting check failure.🧹 Proposed fix
-import io.apitally.common.dto.SpanData;
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
============================================
- Coverage 79.01% 77.47% -1.54%
+ Complexity 408 363 -45
============================================
Files 39 37 -2
Lines 1396 1252 -144
Branches 172 153 -19
============================================
- Hits 1103 970 -133
- Misses 190 197 +7
+ Partials 103 85 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
Release Notes
Removed Features
Configuration Changes
tracing-enabledconfiguration option in request logging settings has been removed. Please remove this setting from your configuration files if present to ensure compatibility.✏️ Tip: You can customize this high-level summary in your review settings.