Fixed Hero Builds; Add Urn of Saint Viktor (ItemID 801) to LootManager#412
Open
Ewoog wants to merge 8 commits intoapoguita:mainfrom
Open
Fixed Hero Builds; Add Urn of Saint Viktor (ItemID 801) to LootManager#412Ewoog wants to merge 8 commits intoapoguita:mainfrom
Ewoog wants to merge 8 commits intoapoguita:mainfrom
Conversation
Co-authored-by: Ewoog <72410352+Ewoog@users.noreply.github.com>
…ading Fix LoadHeroSkillTemplate - Clarify party position parameter and add hero_id/name helpers
# Conflicts: # Py4GWCoreLib/routines_src/Yield.py
The map verify timeout was caused by a race condition where the Party cache was not being updated immediately after a map finished loading. This change tracks the map loading state and ensures Party._update_cache() is called not only during map loading, but also immediately after the map transitions from loading to ready state. This eliminates the window where IsPartyLoaded() could return stale data during map verification. Co-authored-by: Ewoog <72410352+Ewoog@users.noreply.github.com>
Fix map verify timeout by ensuring Party cache updates on loading transitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.