Skip to content

Skill System, SkillProperties, Inventory Native Context, CombatEvents Improvements#546

Open
HamsterSerious wants to merge 6 commits intoapoguita:mainfrom
HamsterSerious:main
Open

Skill System, SkillProperties, Inventory Native Context, CombatEvents Improvements#546
HamsterSerious wants to merge 6 commits intoapoguita:mainfrom
HamsterSerious:main

Conversation

@HamsterSerious
Copy link
Copy Markdown
Contributor

Reworked Skill.py with new Target, Combo, Weapon, and Range helper classes for structured skill data queries. Range only exposes what's actually detectable from game flags (Touch, Half Range, Full Range).
Added SkillProperties.py comprehensive skill classification system (interrupts, knockdowns, conditions, hexes, healing, buffs, damage, defense)
Added InventoryContext.py native Python context for weapon sets and item data via memory scanning
Reworked Skillbar.py with SkillUsability IntEnum for structured usability checks instead of string comparisons. Simplified GetCurrentTemplate().
Extended Inventory.py with native weapon set methods (GetActiveWeaponSetIndex, GetWeaponSet, etc.)
Extended Item.py with Weapon subclass for base damage lookups and O(1) weapon type resolution
Improved CombatEvents.py: EventType is now an IntEnum for type safety, rewrote can_act() to properly distinguish auto-attack vs aftercast (behavior change from previous simple check)
Updated Checks.py to delegate IsSkillReady to SkillBar to avoid duplicate logic
Added SkillDataTester widget for testing/demoing skill and skillbar functions

Important Note
I haven't had time to work on this for the past week. During that time, upstream files I had been working in have changed. I've done my best to properly merge my changes on top of the latest upstream, but it would be appreciated if you could double-check the merged files particularly CombatEvents.py, Context.py, Checks.py, and types.py to make sure nothing was lost or broken in the merge.

@apoguita
Copy link
Copy Markdown
Owner

apoguita commented Feb 7, 2026

ill take your changes and add them manually from my branch so i can test step by step, since its a core funcitonality testing it alltogether could be a bit overwhelming

@apoguita
Copy link
Copy Markdown
Owner

migrated and integreated combat events manually, sorry took this long :( , ill integrate the rest shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants