[BUILD_MGR] Added SOS and ST#835
Open
markpnoi26 wants to merge 2 commits intoapoguita:mainfrom
Open
Conversation
reid15halo-ops
added a commit
to reid15halo-ops/Py4GW
that referenced
this pull request
May 4, 2026
…alist builds) - Move spirit spawn/step-away wait to after SetTickSuccess in CastSkillID and CastSkillSlot - Add CanCastSkillID guard in CastSpiritSkillID to fail early - Add SpiritBuffExists check in Communing._cast_protective_spirit to prevent duplicate spirits - Add __init__.py for Ritualist package directories The new SOS.py/Soul_Twisting.py build files from the PR are skipped as our fork already has more advanced versions (SoS Spirit Spammer.py, Soul Twisting.py). The ChannelingMagic.py replacement is also skipped as our version includes Spirit_Siphon, Armor_of_Unfeeling, and ownership-aware spirit checks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
placed after post-cast yields, both incompatible with the headless tree's single-step next() generator consumption
Details
New builds:
BuildMgr fixes (affects all spirit builds):
Skill implementations: