fix: include default deprecation reason in the composed supergraph#3377
Closed
dariuszkuc wants to merge 4 commits intomainfrom
Closed
fix: include default deprecation reason in the composed supergraph#3377dariuszkuc wants to merge 4 commits intomainfrom
dariuszkuc wants to merge 4 commits intomainfrom
Conversation
`@deprecated` reason used to be optional in the past and as such it was omitted from the supergraph schema. [Reason is no longer optional](graphql/graphql-spec#1040) so we should always include it (even if it is a default).
🦋 Changeset detectedLatest commit: 56640ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 30c8aaf20439f0e45fe86a77 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Member
Author
|
Current behavior is correct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@deprecatedreason used to be optional so if a subgraph does not specify the reason, it is omitted from the supergraph schema. Reason is no longer optional so we should always include it (even if it has a default value).