mock: remove aliases to types being deprecated in Testify#229
Open
dolmen wants to merge 1 commit intoappable-run:masterfrom
Open
mock: remove aliases to types being deprecated in Testify#229dolmen wants to merge 1 commit intoappable-run:masterfrom
dolmen wants to merge 1 commit intoappable-run:masterfrom
Conversation
The Testify project (github.com/stretchr/testify/mock) has unfortunately
exposed types AnythingOfTypeArgument and IsTypeArgument which should
have stayed implementation details. They should have been private types
hidden behind an interface.
Those types have function constructors that must be used instead:
mock.AnythingOfTypeArgument("string") -> mock.AnythingOfType("string")
*mock.IsTypeArgument
The references to those concrete types in downstream projects are blocking
the cleanup of the Testify API.
appy/mock unfortunately propagate those mistakes.
The appy project contains the only public reference to
mock.IsTypeArgument on the whole GitHub:
https://github.com/search?q=mock.IsTypeArgument+language%3Ago&type=code
... but it is not used beyond being exposed on the appy/mock package.
So this patch just deletes the two references to AnythingOfTypeArgument
and IsTypeArgument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Testify project has unfortunately exposed types
AnythingOfTypeArgumentandIsTypeArgumentwhich should have stayed implementation details. They should have been private types hidden behind an interface.Those types have function constructors that must be used instead:
mock.AnythingOfTypeArgument("string")->mock.AnythingOfType("string")*mock.IsTypeArgument->mock.IsTypeThe references to those concrete types in downstream projects are blocking the cleanup of the Testify API.
appy/mock unfortunately propagate those mistakes. The appy project contains the only public reference to mock.IsTypeArgument on the whole GitHub: https://github.com/search?q=mock.IsTypeArgument+language%3Ago&type=code
... but it is not used beyond being exposed on the appy/mock package.
So this patch just deletes the two references to
AnythingOfTypeArgumentandIsTypeArgumentin packagemock.Note: I'm a co-maintainer of the Testify project.