Skip to content

fix: keep PR comments best effort#3

Merged
nichenqin merged 1 commit into
mainfrom
fix/pr-comment-best-effort
May 7, 2026
Merged

fix: keep PR comments best effort#3
nichenqin merged 1 commit into
mainfrom
fix/pr-comment-best-effort

Conversation

@nichenqin

Copy link
Copy Markdown
Contributor

Summary

  • make optional PR comment publishing best-effort so GitHub API permission failures do not fail successful deploys or cleanups
  • document comment failures as warnings

Validation

  • bash -n scripts/install-appaloft.sh scripts/run-deploy.sh scripts/resolve-control-plane.sh
  • ruby YAML parse for action.yml and .github/workflows/ci.yml
  • git diff --check

@nichenqin nichenqin merged commit be6a901 into main May 7, 2026
1 check passed
@nichenqin nichenqin deleted the fix/pr-comment-best-effort branch May 7, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant