Add local network access permission to iframe#6
Merged
Conversation
When trying to access https://dash.reactivesearch.io/app/indexName/browse, using the local setup described at https://www.reactivesearch.io/get-started, there is a cor error that happens with the iframe for dejavu, so it doesn't load (chrome). Adding allow="local-network-access" to the iframe makes it work. Only tested by recreating the iframe on chrome devtools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to access https://dash.reactivesearch.io/app/indexName/browse, using the local setup described at https://www.reactivesearch.io/get-started, there is a cor error that happens with the iframe for dejavu, so it doesn't load (chrome).
Adding
allow="local-network-access"to the iframe makes it work. Only tested by recreating the iframe on chrome devtoolsDescribe the change in this PR?
Adds allow="local-network-access" to the iframe used for dejavu at the Browse Data page
How was this PR tested? Provide relevant screenshots
Using chrome dev tools:
allow="local-network-access"to the iframe and copied itallow="local-network-access"to the page againI didn't try running the project locally. The error probably doesn't happen locally as well.
Impact pages list
Browse Data
PR Checklist
yarn cypress:rundev