Skip to content

Synchronized block locks on a mutable field #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tejasae-afk wants to merge 2 commits into
base: stage
Choose a base branch
from
Open

Synchronized block locks on a mutable field #1208

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
541d003
Synchronized block locks on a mutable field
tejasae-afk Apr 18, 2026
d096624
Merge branch 'stage' into fix/synchronized-block-locks-on-a-mutable-fi
tejasae-afk Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions ...src/main/java/jaxp/sun/org/apache/xerces/internal/impl/xpath/regex/RegularExpression.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,15 +722,17 @@ public boolean matches(char[] target, Match match) {
*/
public boolean matches(char[] target, int start, int end, Match match) {

Context ctx;
synchronized (this) {
if (this.operations == null)
this.prepare();
if (this.context == null)
this.context = new Context();
ctx = this.context;
}
Context con = null;
synchronized (this.context) {
con = this.context.inuse ? new Context() : this.context;
synchronized (ctx) {
con = ctx.inuse ? new Context() : ctx;
con.reset(target, start, end, this.numberOfClosures);
}
if (match != null) {
Expand Down Expand Up @@ -907,15 +909,17 @@ public boolean matches(String target, Match match) {
*/
public boolean matches(String target, int start, int end, Match match) {

Context ctx;
synchronized (this) {
if (this.operations == null)
this.prepare();
if (this.context == null)
this.context = new Context();
ctx = this.context;
}
Context con = null;
synchronized (this.context) {
con = this.context.inuse ? new Context() : this.context;
synchronized (ctx) {
con = ctx.inuse ? new Context() : ctx;
con.reset(target, start, end, this.numberOfClosures);
}
if (match != null) {
Expand Down Expand Up @@ -1586,15 +1590,17 @@ public boolean matches(CharacterIterator target, Match match) {



Context ctx;
synchronized (this) {
if (this.operations == null)
this.prepare();
if (this.context == null)
this.context = new Context();
ctx = this.context;
}
Context con = null;
synchronized (this.context) {
con = this.context.inuse ? new Context() : this.context;
synchronized (ctx) {
con = ctx.inuse ? new Context() : ctx;
con.reset(target, start, end, this.numberOfClosures);
}
if (match != null) {
Expand Down