-
Notifications
You must be signed in to change notification settings - Fork 20
ADFA-3753: handle file and build events to update kt source file index #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
itsaky-adfa
wants to merge
8
commits into
stage
Choose a base branch
from
fix/ADFA-3753
base: stage
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2bffbaf
feat: handle file and build events to update kt source file index
itsaky-adfa 8ba361a
fix: possible race when re-assigning job properties
itsaky 7c18010
fix: possible silent-failure when removing deleted files from index
itsaky 671f6f5
fix: compare compilation env kinds for file move events
itsaky 16095ba
fix: do not skip removing source file on file move
itsaky 8efc813
Merge branch 'stage' into fix/ADFA-3753
itsaky e198ed5
fix: ensure scanning job is cancelled before closing KtSymbolIndex
itsaky 4094775
fix: KtFileMetadataIndex is always in-memory
itsaky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 24 additions & 3 deletions
27
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/CompilationKind.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,37 @@ | ||
| package com.itsaky.androidide.lsp.kotlin.compiler | ||
|
|
||
| import java.nio.file.Path | ||
| import kotlin.io.path.extension | ||
|
|
||
| /** | ||
| * The kind of compilation being performed in a [Compiler]. | ||
| */ | ||
| enum class CompilationKind { | ||
| sealed interface CompilationKind { | ||
|
|
||
| /** | ||
| * The types of files this compilation kind accepts. | ||
| */ | ||
| val fileExtensions: List<String> | ||
|
|
||
| /** | ||
| * Whether this compilation kind accepts the given file path. The default | ||
| * implementation simply checks the accepted [fileExtensions]. | ||
| */ | ||
| fun acceptsFile(path: Path): Boolean { | ||
| return path.extension in fileExtensions | ||
| } | ||
|
|
||
| /** | ||
| * The default compilation kind. Mostly used for normal Kotlin source files. | ||
| */ | ||
| Default, | ||
| data object Default : CompilationKind { | ||
| override val fileExtensions = listOf("kt") | ||
| } | ||
|
|
||
| /** | ||
| * Compilation kind for compiling Kotlin scripts. | ||
| */ | ||
| Script, | ||
| data object Script : CompilationKind { | ||
| override val fileExtensions = listOf("kts") | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.