Update Indonesian Translations#1242
Open
mcikadu-dev wants to merge 2 commits intoappdevforall:stagefrom
Open
Conversation
Contributor
📝 Walkthrough
Risks & Best-Practices Notes:
WalkthroughUpdates Indonesian localization in two Termux resource files: rewrites numerous UI strings (bootstrap, errors, permissions, session/keyboard, preferences, issue reporting), and adjusts XML header/formatting and spacing. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@resources/src/main/res/values-in-rID/termux_app_strings.xml`:
- Around line 43-44: The translations for status messages use imperative form;
update the two string resources msg_enabling_terminal_toolbar and
msg_disabling_terminal_toolbar to progressive Indonesian forms by replacing
"Aktifkan Bilah alat Terminal" with "Mengaktifkan Bilah Alat Terminal" and
"Nonaktifkan Bilah alat Terminal" with "Menonaktifkan Bilah Alat Terminal" so
they match the English progressive/status intent.
- Line 75: The translations use imperatives but should reflect progressive
status; update the string values for msg_generating_report,
msg_enabling_terminal_toolbar, and msg_disabling_terminal_toolbar to progressive
Indonesian forms (e.g., use "Membuat laporan…" or "Sedang membuat laporan…" for
msg_generating_report, and "Mengaktifkan Bilah Alat Terminal…" / "Menonaktifkan
Bilah Alat Terminal…" for the toolbar messages) so they convey ongoing action
rather than commands; ensure you preserve punctuation/ellipsis and only change
the string values for those resource names.
In `@resources/src/main/res/values-in-rID/termux_shared_strings.xml`:
- Line 83: The string resource error_termux_app_package_context_not_accessible
contains redundant phrasing ("Akses ... tidak dapat diakses"); update its value
to remove the leading "Akses" so it reads "Konteks paket aplikasi Code on the Go
tidak dapat diakses." to accurately convey "the package context is not
accessible."
- Line 74: Replace the awkward Indonesian sentence "silakan kirimkan pada
repositori tempat laporan tersebut yang sesuai" with a natural phrasing such as
"silakan kirimkan ke repositori yang sesuai" (or "silakan ajukan di repositori
yang sesuai") in the string at
resources/src/main/res/values-in-rID/termux_shared_strings.xml so the GitHub
reporting line reads: "Jika Anda melaporkan masalah di GitHub, silakan kirimkan
ke repositori yang sesuai."
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a46428bc-9c7f-405b-abd7-dd46ad867196
📒 Files selected for processing (3)
resources/src/main/res/values-in-rID/strings.xmlresources/src/main/res/values-in-rID/termux_app_strings.xmlresources/src/main/res/values-in-rID/termux_shared_strings.xml
Fixed minor grammatical issues and typos
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
resources/src/main/res/values-in-rID/termux_app_strings.xml (1)
45-47: Optional: collapse redundant blank lines.Lines 45–47, 77–79, 83–85, and 120–121 introduce two or three consecutive blank lines between string groups. A single blank line between sections is sufficient and matches the style used elsewhere in the file. Purely cosmetic — feel free to ignore.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@resources/src/main/res/values-in-rID/termux_app_strings.xml` around lines 45 - 47, There are several occurrences of multiple consecutive blank lines in termux_app_strings.xml (around the string groups near the earlier sections reported); collapse each run of two or more blank lines into a single blank line so only one empty line separates string groups (e.g., replace the 2–3 consecutive blank lines at the locations noted with a single blank line), keeping all string entries and indentation unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@resources/src/main/res/values-in-rID/termux_app_strings.xml`:
- Around line 45-47: There are several occurrences of multiple consecutive blank
lines in termux_app_strings.xml (around the string groups near the earlier
sections reported); collapse each run of two or more blank lines into a single
blank line so only one empty line separates string groups (e.g., replace the 2–3
consecutive blank lines at the locations noted with a single blank line),
keeping all string entries and indentation unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: aac23dcb-d541-4c73-bfc5-fde29c8b67d4
📒 Files selected for processing (2)
resources/src/main/res/values-in-rID/termux_app_strings.xmlresources/src/main/res/values-in-rID/termux_shared_strings.xml
🚧 Files skipped from review as they are similar to previous changes (1)
- resources/src/main/res/values-in-rID/termux_shared_strings.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes