ADFA-3836-strings.xml-change-initialise-to-initialize and other language fixes#1250
Conversation
📝 WalkthroughString Resource UpdatesChanges Made
Considerations
WalkthroughUpdates Git-related UI strings in Android resources to standardize capitalization (converting title case to lowercase for secondary words), correct American English spelling ("Initialising" to "Initializing"), change interaction verb from "Click" to "Tap", and adjust punctuation in merge conflict messaging. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
resources/src/main/res/values/strings.xml (1)
1257-1257: Consider renaming the resource key frominitialising_clonetoinitializing_clonefor consistency with the Americanized string value.The value is already "Initializing clone…", but the key retains British spelling. This is inconsistent with the PR's goal. The rename affects one reference in
app/src/main/java/com/itsaky/androidide/viewmodel/CloneRepositoryViewModel.kt:114, and Crowdin will automatically handle the key change per repo conventions.Changes required
In
resources/src/main/res/values/strings.xml:- <string name="initialising_clone">Initializing clone…</string> + <string name="initializing_clone">Initializing clone…</string>In
app/src/main/java/com/itsaky/androidide/viewmodel/CloneRepositoryViewModel.kt(line 114):- statusTextResId = R.string.initialising_clone + statusTextResId = R.string.initializing_clone🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@resources/src/main/res/values/strings.xml` at line 1257, Rename the string resource key initialising_clone to initializing_clone in resources/src/main/res/values/strings.xml and update its usage in CloneRepositoryViewModel (reference: CloneRepositoryViewModel.kt, the place that accesses R.string.initialising_clone around the existing call at line ~114) to use R.string.initializing_clone; ensure no other references remain to the old key so Crowdin can pick up the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@resources/src/main/res/values/strings.xml`:
- Line 1257: Rename the string resource key initialising_clone to
initializing_clone in resources/src/main/res/values/strings.xml and update its
usage in CloneRepositoryViewModel (reference: CloneRepositoryViewModel.kt, the
place that accesses R.string.initialising_clone around the existing call at line
~114) to use R.string.initializing_clone; ensure no other references remain to
the old key so Crowdin can pick up the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0983265a-0393-432a-a4eb-2fab515c7120
📒 Files selected for processing (1)
resources/src/main/res/values/strings.xml
No description provided.