Skip to content

ADFA-3836-strings.xml-change-initialise-to-initialize and other language fixes#1250

Merged
hal-eisen-adfa merged 2 commits intostagefrom
ADFA-3836-strings.xml-change-initialise-to-initialize
Apr 26, 2026
Merged

ADFA-3836-strings.xml-change-initialise-to-initialize and other language fixes#1250
hal-eisen-adfa merged 2 commits intostagefrom
ADFA-3836-strings.xml-change-initialise-to-initialize

Conversation

@Elissa-AppDevforAll
Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026

📝 Walkthrough

String Resource Updates

Changes Made

  • Updated "Initialising" to "Initializing" for consistent American English spelling
  • Adjusted capitalization in Git-related UI strings for consistency:
    • "Author Identity" → "Author identity"
    • "Current Branch" → "Current branch"
    • "Git Credentials" → "Git credentials"
    • "Clear Credentials" → "Clear credentials"
    • "Merge Conflicts" → "Merge conflicts"
    • "Abort Merge" → "Abort merge"
    • "Mark Resolved" → "Mark resolved"
  • Changed interaction verb from "Click on the avatar" to "Tap the avatar" for better mobile UX terminology
  • Changed merge conflict message punctuation from exclamation mark ("conflicts!") to period ("conflicts.") for professional tone consistency

Considerations

  • These are translatable strings in an Android application. Any approved translations of these strings will need to be updated to reflect the new wording and capitalization to maintain consistency across languages.
  • The UI terminology change from "Click" to "Tap" is appropriate and follows mobile application conventions.

Walkthrough

Updates Git-related UI strings in Android resources to standardize capitalization (converting title case to lowercase for secondary words), correct American English spelling ("Initialising" to "Initializing"), change interaction verb from "Click" to "Tap", and adjust punctuation in merge conflict messaging.

Changes

Cohort / File(s) Summary
String Resource Updates
resources/src/main/res/values/strings.xml
Standardized capitalization of Git-related UI strings (lowercase for secondary words), corrected spelling ("Initialising" → "Initializing"), changed "Click" to "Tap" for touch interaction, and adjusted merge conflict message punctuation from exclamation to period.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • hal-eisen-adfa
  • jatezzz

Poem

🐰 Through strings I hop with careful case,
Each word finds its proper place,
From "Initialising" to its cleaner form,
Capitalization now the norm!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, so the check cannot evaluate whether the description relates to the changeset. Add a pull request description explaining the rationale for these string changes and any relevant context or guidelines being followed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: converting British English spelling ('Initialise') to American English ('Initialize') and applying related language/style fixes to Git-related UI strings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ADFA-3836-strings.xml-change-initialise-to-initialize

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
resources/src/main/res/values/strings.xml (1)

1257-1257: Consider renaming the resource key from initialising_clone to initializing_clone for consistency with the Americanized string value.

The value is already "Initializing clone…", but the key retains British spelling. This is inconsistent with the PR's goal. The rename affects one reference in app/src/main/java/com/itsaky/androidide/viewmodel/CloneRepositoryViewModel.kt:114, and Crowdin will automatically handle the key change per repo conventions.

Changes required

In resources/src/main/res/values/strings.xml:

-    <string name="initialising_clone">Initializing clone…</string>
+    <string name="initializing_clone">Initializing clone…</string>

In app/src/main/java/com/itsaky/androidide/viewmodel/CloneRepositoryViewModel.kt (line 114):

-                    statusTextResId = R.string.initialising_clone
+                    statusTextResId = R.string.initializing_clone
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@resources/src/main/res/values/strings.xml` at line 1257, Rename the string
resource key initialising_clone to initializing_clone in
resources/src/main/res/values/strings.xml and update its usage in
CloneRepositoryViewModel (reference: CloneRepositoryViewModel.kt, the place that
accesses R.string.initialising_clone around the existing call at line ~114) to
use R.string.initializing_clone; ensure no other references remain to the old
key so Crowdin can pick up the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@resources/src/main/res/values/strings.xml`:
- Line 1257: Rename the string resource key initialising_clone to
initializing_clone in resources/src/main/res/values/strings.xml and update its
usage in CloneRepositoryViewModel (reference: CloneRepositoryViewModel.kt, the
place that accesses R.string.initialising_clone around the existing call at line
~114) to use R.string.initializing_clone; ensure no other references remain to
the old key so Crowdin can pick up the change.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0983265a-0393-432a-a4eb-2fab515c7120

📥 Commits

Reviewing files that changed from the base of the PR and between 65c121a and 425cb94.

📒 Files selected for processing (1)
  • resources/src/main/res/values/strings.xml

@hal-eisen-adfa hal-eisen-adfa merged commit 896ff56 into stage Apr 26, 2026
2 checks passed
@hal-eisen-adfa hal-eisen-adfa deleted the ADFA-3836-strings.xml-change-initialise-to-initialize branch April 26, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants