Skip to content

ADFA-3867: member completions do not show up without non-empty partial #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itsaky-adfa merged 1 commit into from
Apr 28, 2026
+5 −5
Merged

ADFA-3867: member completions do not show up without non-empty partial #1260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/completion/KotlinCompletions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,6 @@ internal fun doComplete(params: CompletionParams): CompletionResult {
val prefix = params.requirePrefix()
val partial = partialIdentifier(prefix)

if (partial.isBlank()) {
logger.warn("cannot complete for blank partial candidate")
return CompletionResult.EMPTY
}

abortIfCancelled()

// insert placeholder to fix broken trees
Expand Down Expand Up @@ -294,6 +289,11 @@ context(env: CompilationEnvironment, ctx: AnalysisContext)
private fun KaSession.collectScopeCompletions(
to: MutableList<CompletionItem>,
) {
if (ctx.partial.isBlank()) {
logger.warn("cannot complete for blank partial candidate")
return
}

abortIfCancelled()

val ktElement = ctx.ktElement
Expand Down
Loading