ADFA-3870: mainline Kotlin LSP

[itsaky-adfa]

Makes the Kotlin LSP mainline so that it can be used without turning on experimental features.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b5479823-f206-4b7e-848d-e8f5539146a6

📥 Commits

Reviewing files that changed from the base of the PR and between 14898ac and 9f11acd.

📒 Files selected for processing (1)

• app/src/main/java/com/itsaky/androidide/handlers/LspHandler.kt

---

📝 Walkthrough

Release Notes

• Kotlin LSP is no longer gated behind experimental features: The Kotlin Language Server is now mainline and available to all users without requiring experimental features to be enabled

• Automatic Kotlin LSP initialization: The language server is now unconditionally ensured to be present at runtime, registering automatically if not already loaded

• Java and XML LSP unaffected: No changes to the registration behavior of Java or XML language servers

Risks and Best Practices Notes

• ⚠️ Feature promotion from experimental: Kotlin LSP has been promoted from experimental status to mainline without an explicit feature flag toggle. Users cannot opt-out without code changes

• ⚠️ No graceful degradation path: Unlike the previous implementation, there is now no way to disable Kotlin LSP if users encounter issues, as the feature flag has been removed

• Recommendation: Consider maintaining an alternative feature flag or configuration option to allow users to disable the Kotlin LSP if stability issues arise in production

Walkthrough

The Kotlin language server registration in registerLanguageServers is modified to unconditionally register the server when absent, removing the prior feature flag dependency. Java and XML server registration logic remains unaffected.

Changes

Cohort / File(s)	Summary
Kotlin LSP Server Registration app/src/main/java/com/itsaky/androidide/handlers/LspHandler.kt	Removed feature flag condition gating Kotlin LSP server registration; server is now unconditionally ensured to be present by registering it when getServer(KotlinLanguageServer.SERVER_ID) returns null.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• ADFA-3319: add basic K2-based Kotlin diagnostic provider #1112 — Modifies KotlinLanguageServer with diagnostic provider and session setup changes that directly depend on the registration logic change in this PR.

Suggested reviewers

• jatezzz
• dara-abijo-adfa

Poem

🐰 No flags to guard the Kotlin way,
A server springs to life today!
Unconditional and always there,
The rabbit hops without a care! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically summarizes the main change: moving Kotlin LSP from experimental to mainline feature.
Description check	✅ Passed	The description is directly related to the changeset, explaining the purpose of removing the experimental feature gate for Kotlin LSP.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/ADFA-3870

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}