Skip to content

refactor: remove deprecated WDA settings/capabilities and idb typing#1124

Merged
mykola-mokhnach merged 2 commits intomasterfrom
v12
Apr 14, 2026
Merged

refactor: remove deprecated WDA settings/capabilities and idb typing#1124
mykola-mokhnach merged 2 commits intomasterfrom
v12

Conversation

@mykola-mokhnach
Copy link
Copy Markdown

Drop deprecated public API surface and related internal wiring:

  • remove AppleDevice.idb from TypeScript types
  • remove includeNonModalElements setting handling
  • remove shouldUseTestManagerForVisibilityDetection capability handling
  • remove deprecated SSLSetEnableCertVerify path from vendored GCDAsyncSocket

BREAKING CHANGE: remove idb from AppleDevice; clients must stop passing device.idb.
BREAKING CHANGE: remove includeNonModalElements WDA setting; clients must stop sending this setting in /settings.
BREAKING CHANGE: remove shouldUseTestManagerForVisibilityDetection capability; clients must stop sending this desired capability.

@mykola-mokhnach
Copy link
Copy Markdown
Author

@eglitise
Copy link
Copy Markdown

It seems like there aren't any iOS 15 related ones in the rest of the code. Do we want to leave the Xcode 14/iOS 16 related macros as is?

I also found a few other occurrences of older macros:
https://github.com/appium/WebDriverAgent/blob/master/WebDriverAgentLib/Vendor/CocoaAsyncSocket/GCDAsyncSocket.m#L7387
https://github.com/appium/WebDriverAgent/blob/master/WebDriverAgentTests/IntegrationTests/FBAlertTests.m#L35

@mykola-mokhnach
Copy link
Copy Markdown
Author

https://github.com/appium/WebDriverAgent/blob/master/WebDriverAgentLib/Vendor/CocoaAsyncSocket/GCDAsyncSocket.m#L7387

removed

https://github.com/appium/WebDriverAgent/blob/master/WebDriverAgentTests/IntegrationTests/FBAlertTests.m#L35

still there because iOS 13 is set as the minimum version. I did not want to bump that yet

@mykola-mokhnach mykola-mokhnach merged commit 5072e25 into master Apr 14, 2026
46 of 47 checks passed
@mykola-mokhnach mykola-mokhnach deleted the v12 branch April 14, 2026 18:30
github-actions Bot pushed a commit that referenced this pull request Apr 14, 2026
## [12.0.0](v11.4.3...v12.0.0) (2026-04-14)

### ⚠ BREAKING CHANGES

* remove idb from AppleDevice; clients must stop passing device.idb.
* remove includeNonModalElements WDA setting; clients must stop sending this setting in /settings.
* remove shouldUseTestManagerForVisibilityDetection capability; clients must stop sending this desired capability.

### Code Refactoring

* remove deprecated WDA settings/capabilities and idb typing ([#1124](#1124)) ([5072e25](5072e25))
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 12.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants