feat: add method for interacting with the Flutter integration driver#1123
Merged
mykola-mokhnach merged 3 commits intoappium:masterfrom May 5, 2025
Merged
Conversation
appium/webdriver/extensions/flutter_integration/flutter_commands.py
Outdated
Show resolved
Hide resolved
| text (Optional[str]): The text of the widget to filter by. | ||
|
|
||
| Returns: | ||
| List[Optional[Dict]]: A list of dictionaries or None values representing the render tree. |
Contributor
There was a problem hiding this comment.
It might probably be useful to provide some examples of the output
Contributor
Author
There was a problem hiding this comment.
I've updated the main comment with the output examples
Contributor
There was a problem hiding this comment.
are you sure the recent changes have been committed?
Contributor
Author
There was a problem hiding this comment.
did you mean that the output examples should be included in the function's docstring?
Contributor
There was a problem hiding this comment.
yes, one or two would be enough for the returned value docstring
Contributor
Author
There was a problem hiding this comment.
added example for the returned value in the docstring
mykola-mokhnach
approved these changes
May 4, 2025
KazuCocoa
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds a method for interacting with the Flutter integration driver. It adds partial filter support and render tree retrieval.
Please let me know if any changes or improvements are needed.
Thanks!
This is an example of the output for this method, based on the rendering of this application
REQUEST of the existing class
RESPONSE
REQUEST for a non-existent widget
RESPONSE
REQUEST without parameters to retrieve all widgets from the root
RESPONSE