Add Tensor.unfold op support for PyTorch frontend#2672
Merged
TobyRoseman merged 2 commits intoapple:mainfrom Apr 14, 2026
Merged
Add Tensor.unfold op support for PyTorch frontend#2672TobyRoseman merged 2 commits intoapple:mainfrom
TobyRoseman merged 2 commits intoapple:mainfrom
Conversation
Collaborator
Contributor
Author
Thanks for triggering the CI. The failures is from ExecuTorch frontend. Since aten.unfold is not in the Core ATen opset, so ExecuTorch's verifier rejects it before coremltools runs. I've pushed a fix to solve this issue. Could you retrigger CI when you get a chance? |
Collaborator
TobyRoseman
approved these changes
Apr 14, 2026
Collaborator
|
@jathinsn27 - thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aten::unfold(Tensor.unfold(dimension, size, step)), which was previously unsupportedsliding_windowsop with a transpose to match PyTorch's output layoutFixes #2599
Test
TestTensorUnfoldwith 5 parametrized cases covering different axes, step sizes, negative indexing, and rank-4 vision inputtest_chained_unfoldfor back-to-back unfold callsop 'unfold' not implemented) and pass with it