Detection of How One Sorted Sequence Includes Another#38
Open
CTMacUser wants to merge 10 commits intoapple:mainfrom
Open
Detection of How One Sorted Sequence Includes Another#38CTMacUser wants to merge 10 commits intoapple:mainfrom
CTMacUser wants to merge 10 commits intoapple:mainfrom
Conversation
Add method to sequences that takes another sequence and a comparison predicate, assumes both sequences are sorted along that predicate, and reports how much the sequences overlap in element values. Add an overload that defaults the comparison to the standard less-than operator. Add a type to express the form of set overlap, making optional distinction to degenerate sources.
Rename the type expressing kinds of set overlap, to be less general. Explicitly list the preconditions for the set-overlap detection methods.
Forgot to update a file for a type rename from the last change.
4 tasks
Add a reference to the pull-request link. Change location of summary.
Change the name of the "sortedOverlap" methods to "degreeOfInclusion," to clarify what is being calculated.
Change the name of the source, test, and guide files to match the updated method name. Update their link in the README file.
Change some paragraphs with better explanations on design and usage. Change punctuation spacing to match the project's style.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new API for detecting how two already sorted sequences overlap. It is a generalization of the
includesfunction from C++. It returns a custom type instead of a Boolean.Detailed Design
Documentation Plan
The methods, type, and the type's cases and properties have block documents. There is also a guide file.
Test Plan
A test file is included.
Source Impact
It adds API.
Checklist