Open
Conversation
Member
|
There are a few additional steps here we would likely want to do to go after this:
generally i do wonder if it needs the buffering of the AsyncStream underpinning it, could it perhaps use flatMap + reduce to practically achieve the same thing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added an initial implementation of split that I'm using in my own project, and appears to work there. I'm aware that this PR is currently incomplete, but I'd like to know whether this is something people feel is worth adding here, and if so, if this is the right design, before building out the rest of the stuff (units tests etc).
There are currently two different split implementations, one returning an async sequence of collections and the other returning an async sequence of async sequences.
I can see value in both, and one of the questions that warrants this Request for Comments is which is preferred, or whether both should be included.