SwiftQUIC: PERF: acknowledgedSendDataInner is using too much CPU#17
Open
agnosticdev wants to merge 1 commit into
Open
SwiftQUIC: PERF: acknowledgedSendDataInner is using too much CPU#17agnosticdev wants to merge 1 commit into
agnosticdev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
StreamSendBufferacknowledgedSendDataInner does a insert and removal operation for almost all ACKs that are processed. This is very costly based on the CPU metrics below.The new change uses a custom struct that holds an array of
Range<StreamOffset>to not pay the overhead of dealing with Set operations on each ACK. acknowledgedSendDataInner now has two branches, a in-order branch that only does a remove operation, and an out of order path that still falls back to using both an insert and remove operation. The result of this is about a 7.3 gigacycle reduction in CPU for QUICTransfer:Baseline:
With this change: