agnosticdev/AckBundling: SwiftQUIC: Improve ACK Bundling#5
Merged
Conversation
rpaulo
approved these changes
Jun 10, 2026
tfpauly
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change utilizes the ACK delay timer to pickup and send one-off ACKs that were not previously being bundled with stream frames in the same packet.
I did some analysis when SwiftQUIC was being used on the server and found that when h2load makes 5000 HTTP3 GET requests for 1k we are sending back 7557 packets back to h2load.
For example:
This did not seem correct because the 1k stream frames should not have taken up the entire packet. Upon evaluating the packet trace I found that we were not bundling ACK frames as efficiently as we could. This change improves that situation and now I see:
So almost all of the QUIC packets that carry the HTTP3 response also contain a bundle ACK ase well.