Merged
Conversation
Contributor
Author
|
(merging into staging so I can build on top of it) |
Member
|
@milseman does it make sense to adopt Span in any of these API? |
FranzBusch
reviewed
Jan 19, 2026
| /// An IPv4 address consists of a 32-bit IP address and a 16-bit port number. | ||
| @frozen | ||
| @available(System 99, *) | ||
| public struct IPv4Address: Sendable, Equatable, Hashable { |
Member
There was a problem hiding this comment.
Can we nest this type inside SocketAddress since it is tied to this and not a Swift native IP address implementation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a merge-ready port of #30 into the
stagingbranch.The
stagingbranch is new. My intention is that we can land near-term additions there, especially as they start to interact with each other (e.g. process ids and signals). I'm also merging @lorentey's awesome sample apps in tostaging; we want more of this.The original PR was largely developed by myself and @lorentey long before a lot of Swift's modern features and System has evolved a little bit since then.
I'll be slowly doing a pass over the original PR thread's comments, see what's relevant, etc. I've also not scoured the diff for vestigial code.
@lorentey or @glessard would you be interested in taking a glance over
_RawBufferand seeing if there's a better approach now?