[Implementation] Back-deploy CInterop.stat for Migration Compatibility#299
Merged
jrflat merged 1 commit intoapple:mainfrom Mar 3, 2026
Merged
Conversation
Contributor
|
I still think this sets a bad precedent for every method we add that enviably shadows a global function. |
Contributor
Author
I agree we should not do this for most, if not all, other methods that shadow a global function. I think
So I think this |
Contributor
Author
|
@swift-ci please test |
glessard
approved these changes
Mar 2, 2026
Contributor
|
is there a way to mark: as externally deprecated to move users off? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR back-deploys
CInterop.stat(_:_:)andCInterop.Statto the originalCInteropavailability to help developer migration in rare cases whereFilePath.stat()andFileDescriptor.stat()conflict with existing usage of unqualifiedstat()in extensions of those types.See the pitch at: https://forums.swift.org/t/pitch-back-deploy-system-cinterop-stat-for-migration-compatibility/84930
See the full proposal in #298