Conversation
|
This is close to being mergeable, but still has the global system call design question as #33 |
| /// | ||
| /// - Parameters: | ||
| /// - path: The location of the file to open. | ||
| /// - at: if `path` is relative, treat it as relative to this file descriptor |
There was a problem hiding this comment.
Nit: we should not use prepositions as variable names.
| /// - at: if `path` is relative, treat it as relative to this file descriptor | |
| /// - base: if `path` is relative, treat it as relative to this file descriptor |
Or we could just call it fd.
| @_alwaysEmitIntoClient | ||
| public static func open( | ||
| _ path: FilePath, | ||
| at: FileDescriptor, |
There was a problem hiding this comment.
| at: FileDescriptor, | |
| at base: FileDescriptor, |
(etc, throughout this PR.)
|
I'd be happy with either option! I like |
|
I much prefer edit: Oh right, that is ignored if the incoming path is absolute. edit 2: The existence of |
No description provided.