Skip to content

fix #538: use 1 logger#637

Draft
slimus wants to merge 3 commits intoappleboy:masterfrom
slimus:use-one-instance-of-logger
Draft

fix #538: use 1 logger#637
slimus wants to merge 3 commits intoappleboy:masterfrom
slimus:use-one-instance-of-logger

Conversation

@slimus
Copy link
Copy Markdown
Contributor

@slimus slimus commented Oct 25, 2021

We used 2 different systems for logging.

Now I removed old log system and use one logger everywhere

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 25, 2021

Codecov Report

❌ Patch coverage is 18.18182% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.04%. Comparing base (9d47494) to head (01526be).
⚠️ Report is 306 commits behind head on master.

Files with missing lines Patch % Lines
logx/log.go 0.00% 36 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
- Coverage   65.05%   64.04%   -1.02%     
==========================================
  Files          21       21              
  Lines        1783     1808      +25     
==========================================
- Hits         1160     1158       -2     
- Misses        562      591      +29     
+ Partials       61       59       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@appleboy
Copy link
Copy Markdown
Owner

@slimus Thanks for your effort. Maybe I can improve the gin/logger package not copy the source code from gin/logger.

@slimus
Copy link
Copy Markdown
Contributor Author

slimus commented Oct 26, 2021

It would be great :)

@slimus slimus marked this pull request as draft October 26, 2021 04:12
@appleboy appleboy force-pushed the master branch 2 times, most recently from 60a7a68 to 2c29b4b Compare June 30, 2022 15:02
@appleboy appleboy force-pushed the master branch 4 times, most recently from bff0f2d to 6b6ef69 Compare December 24, 2022 13:02
@markhemstead
Copy link
Copy Markdown
Contributor

Is there any traction on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants