Skip to content

fix(router): resolve memory leak from uncancelled contexts in async mode #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
appleboy merged 2 commits into from
Mar 21, 2026
+7 −13
Merged

fix(router): resolve memory leak from uncancelled contexts in async mode #866

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a282bde
fix(router): resolve memory leak from uncancelled contexts in async mode
a020792s Mar 18, 2026
8809866
Merge branch 'master' into claude/blissful-shockley
appleboy Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions router/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,19 +86,13 @@ func pushHandler(cfg *config.ConfYaml, q *queue.Queue) gin.HandlerFunc {
return
}

ctx, cancel := context.WithCancel(context.Background())
go func() {
// Deprecated: the CloseNotifier interface predates Go's context package.
// New code should use Request.Context instead.
// Change to context package
<-c.Request.Context().Done()
// Don't send notification after client timeout or disconnected.
// See the following issue for detail information.
// https://github.com/appleboy/gorush/issues/422
if cfg.Core.Sync {
cancel()
}
}()
// Use the request context directly so the context lifecycle is tied
// to the HTTP request. This avoids leaking a context.WithCancel on
// every request when running in async mode (sync: false), which was
// the root cause of the memory leak described in:
// https://github.com/appleboy/gorush/issues/422
// https://github.com/appleboy/gorush/issues/518
ctx := c.Request.Context()

counts, logs := handleNotification(ctx, cfg, form, q)

Expand Down
Loading