Skip to content

chore(youbora-improvement) : TODO- improvement #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
VanjaPin wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore(youbora-improvement) : TODO- improvement #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions src/components/YouboraAnalytics/InfoManager.brs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,3 +729,59 @@ function InfoManager_getFromInnerAsocArray(dict as object, dictName as string, k

return invalid
end function

'//TODO potential improvement:

' contentAttributes = m.getContentAttributes(requestName)
' m.updateOuterParam(m.plugin, contentAttributes)
' m.updateOuterParam(m.options.content, contentAttributes)
' m.updateOuterParam(m.options, contentAttributes)

' function getContentAttributes(key as string)
' data = {
' "adStop": {
' "playhead": "getPlayHead"
' "adNumber": "getAdNumber"
' }
' "adPause": {
' },
' "start": {
' "userType": "usertype"
' "userType_alternative": "user.type"
' "deviceId": "device.code"
' }
' "data": {
' "system": "accountCode"
' "pluginName": "getPluginName"
' }
' "sessionStart": {
' "navContext": "RokuPlugin"
' "pluginName": "getPluginName"
' "pluginVersion": "getPluginVersion"
' "obfuscateIp": "user.obfuscateIp"
' "deviceUUID": "channelClientId"
' }
' "sessionNav": {
' "username": "username"
' "username": "user.name_alternative"
' "navContext": "RokuPlugin"
' "route": "Roku"
' }
' }

' return data
' end function


' function updateOuterParams(values as aaa, contentAtrributes)
' for each attribute in contentAttributes.items()
' outParams[attribute.key] = outParams[attribute.key] = invalid ? values[attribute.value] : outParams[attribute.key]
' if mc.isFunction m[attribute.key]
' outParams[attribute.key] = m[attribute.key]()
' end if
' if values[attribute.key] = invalid
' 'use alternative
' outParamas[attribute.key] = values[`${attribute.key}_alternative`]
' end if
' end for
' end function