Open
Conversation
Author
|
@alexzchut could you please take a look at this one when you have a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add optional SCM tag parameter to SDK creation task
Overview
This PR adds an optional
scm_tagparameter to thezapp_sdks:createrake task, allowing users to specify a custom SCM tag that differs from the version number.Background
Currently, the
zapp_sdk_tasksgem hardcodes the SCM tag to match the version number. However, for platform-specific releases like TV 7.0.2, we need the ability to use platform-specific tags (e.g.,webos-7.0.2,tizen-7.0.2) while maintaining the same base version number.Changes
scm_tagparameter to thezapp_sdks:createrake taskSdkHelper.zapp_request_paramsmethod to use the provided SCM tag, falling back to the version if not providedTesting
All specs have been updated and tested with:
Example Usage
Before:
After:
Backward Compatibility
This change is fully backward compatible. Existing scripts that don't provide the SCM tag will continue to work as before, using the version as the SCM tag.