Skip to content

feat: add scm tag arg to create task#19

Open
sherwino wants to merge 2 commits intomasterfrom
feat-add-scm-tag
Open

feat: add scm tag arg to create task#19
sherwino wants to merge 2 commits intomasterfrom
feat-add-scm-tag

Conversation

@sherwino
Copy link
Copy Markdown

@sherwino sherwino commented Apr 11, 2025

Description

Add optional SCM tag parameter to SDK creation task

Overview

This PR adds an optional scm_tag parameter to the zapp_sdks:create rake task, allowing users to specify a custom SCM tag that differs from the version number.

Background

Currently, the zapp_sdk_tasks gem hardcodes the SCM tag to match the version number. However, for platform-specific releases like TV 7.0.2, we need the ability to use platform-specific tags (e.g., webos-7.0.2, tizen-7.0.2) while maintaining the same base version number.

Changes

  • Added an optional scm_tag parameter to the zapp_sdks:create rake task
  • Updated the SdkHelper.zapp_request_params method to use the provided SCM tag, falling back to the version if not provided
  • Added appropriate test cases for the new functionality
  • Updated the README to document the new parameter and include the additional supported platforms (samsung_tv, lg_tv, vizio)

Testing

All specs have been updated and tested with:

  • No SCM tag provided (maintains backward compatibility)
  • Custom SCM tag provided

Example Usage

Before:

bundle exec rake zapp_sdks:create[webos,7.0.2,zapp-web-tvs,token]
# Uses scm_tag = "7.0.2"

After:

bundle exec rake zapp_sdks:create[webos,7.0.2,zapp-web-tvs,token,webos-7.0.2]
# Uses scm_tag = "webos-7.0.2"

Backward Compatibility

This change is fully backward compatible. Existing scripts that don't provide the SCM tag will continue to work as before, using the version as the SCM tag.

@sherwino
Copy link
Copy Markdown
Author

@alexzchut could you please take a look at this one when you have a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant