fix: update BetterBugs recording links to use new package URLs#41667
fix: update BetterBugs recording links to use new package URLs#41667sebastianiv21 wants to merge 2 commits intoreleasefrom
Conversation
- Changed the script source URLs for BetterBugs recording links from `cdn.betterbugs.io` to `pkg.betterbugs.io`. - Updated the comment to include a direct link to BetterBugs documentation for workspace settings related to recording links.
|
/build-deploy-preview skip-tests=true |
WalkthroughUpdated the BetterBugs recording-link loader in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/23671123334. |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/client/public/index.html (1)
85-90: Ensurepkg.betterbugs.iois included in CSPscript-srcallowlists for hardened deployments.Currently, no
script-srcdirective restricts script loading. Ifscript-srcCSP is added in the future, the BetterBugs scripts atpkg.betterbugs.iowill fail silently unless the domain is explicitly allowlisted.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/client/public/index.html` around lines 85 - 90, The BetterBugs loader scripts are injected via s1.src and s2.src in index.html and will be blocked if a strict Content-Security-Policy with a script-src directive is applied; update your CSP (meta tag or server header) to explicitly allow the host pkg.betterbugs.io in the script-src allowlist (in addition to 'self' as appropriate) so the scripts referenced by s1.src and s2.src can load in hardened deployments.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/client/public/index.html`:
- Around line 84-91: Replace the top-level `var` declarations for the script
elements with block-scoped `const` to avoid creating global window properties;
specifically update the `s1` and `s2` declarations used when creating the
logs-capture and recorder script elements so they are declared as `const s1 =
document.createElement("script")` and `const s2 =
document.createElement("script")`, leaving the rest of the logic (setting `src`,
`async`, and appending to `document.head`) unchanged.
---
Nitpick comments:
In `@app/client/public/index.html`:
- Around line 85-90: The BetterBugs loader scripts are injected via s1.src and
s2.src in index.html and will be blocked if a strict Content-Security-Policy
with a script-src directive is applied; update your CSP (meta tag or server
header) to explicitly allow the host pkg.betterbugs.io in the script-src
allowlist (in addition to 'self' as appropriate) so the scripts referenced by
s1.src and s2.src can load in hardened deployments.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7133c96e-9e5e-40d7-b97b-cb0ab9af3365
📒 Files selected for processing (1)
app/client/public/index.html
…ndex.html - Updated variable declarations for script elements from `var` to `const` to enhance code clarity and maintainability.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/client/public/index.html (1)
85-90: Third-party script loading is stable.Both BetterBugs endpoints are reachable with proper cache headers (
max-age=120), indicating BetterBugs actively manages the/latestendpoint. Pinning versions would add maintenance overhead; the current approach is acceptable for external services.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/client/public/index.html` around lines 85 - 90, No code change is required here: keep the two script elements using s1.src = "https://pkg.betterbugs.io/scripts/latest/logs-capture.js" and s2.src = "https://pkg.betterbugs.io/scripts/latest/recorder.js" as-is (do not pin versions), since the reviewer confirmed the /latest endpoints are stable and served with proper cache headers; simply ensure s1 and s2 remain created and appended the same way in this file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@app/client/public/index.html`:
- Around line 85-90: No code change is required here: keep the two script
elements using s1.src =
"https://pkg.betterbugs.io/scripts/latest/logs-capture.js" and s2.src =
"https://pkg.betterbugs.io/scripts/latest/recorder.js" as-is (do not pin
versions), since the reviewer confirmed the /latest endpoints are stable and
served with proper cache headers; simply ensure s1 and s2 remain created and
appended the same way in this file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 84a276c9-3907-4f71-bba4-58eb7344daec
📒 Files selected for processing (1)
app/client/public/index.html
|
Deploy-Preview-URL: https://ce-41667.dp.appsmith.com |
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/23671514633. |
|
Deploy-Preview-URL: https://ce-41667.dp.appsmith.com |
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
cdn.betterbugs.iotopkg.betterbugs.io.Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Sanity"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/23671351342
Commit: f44e178
Cypress dashboard.
Tags:
@tag.SanitySpec:
Fri, 27 Mar 2026 23:52:07 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit