Add offline search + Ask AI coming-soon, resolve all npm audit vulnerabilities#16
Merged
Conversation
Add a segmented navbar search control adapted from appsmith-docs: - Search: powered by the offline @easyops-cn/docusaurus-search-local plugin, which builds the index from Markdown at build time. Chosen over Algolia so search works immediately with no external index or live-site crawl. - Ask AI: an intentional "coming soon" placeholder (no OpenAI key or serverless function), cleanly isolated for a later swap. Swizzles theme/SearchBar to wrap the original search bar, inlines the robot icon so it recolors via currentColor in dark mode, and documents that the search index only builds via `npm run build` (not `npm start`). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- npm audit fix (non-breaking) bumped @docusaurus/* 3.9.2 -> 3.10.1 (within the existing ^3.9.2 range) and patched leaf deps, clearing the critical shell-quote advisory and others (49 -> 24). - Added npm overrides pinning the two remaining vulnerable transitive build/dev-only deps to their patched releases: - serialize-javascript ^7.0.5 (high; via webpack copy/minimizer plugins) - uuid ^11.1.1 (moderate; via webpack-dev-server -> sockjs) npm audit now reports 0 vulnerabilities. Verified: production build succeeds and still generates the search index, and the dev server (npm start, which exercises the overridden uuid via sockjs) boots and compiles cleanly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
wyattwalter
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the two search-related features from
appsmith-docs, adapted for Kite, and clears the repo's npm audit vulnerabilities.Search (works now)
@easyops-cn/docusaurus-search-local— builds the index from Markdown at build time. Chosen over Algolia so search works immediately with no external index or live-site crawl to provision.theme/SearchBarwrapping the original search bar).Ask AI (coming soon)
AskAIComingSoon) so it can be swapped for a real assistant later by changing one import.Dependency hygiene
npm audit fix(non-breaking) bumped@docusaurus/*3.9.2 → 3.10.1 within the existing range and cleared the criticalshell-quoteadvisory among others.overridespinning the two remaining vulnerable, build/dev-only transitive deps to patched releases:serialize-javascript ^7.0.5anduuid ^11.1.1.npm auditnow reports 0 vulnerabilities. (Merging clears the Dependabot alerts onmain.)Review
A multi-agent council reviewed the change (architecture, security, QA, UX, product, DX, performance) → APPROVE WITH RISKS, all findings resolved or tracked. A targeted security re-review of the dependency change → APPROVE (override targets verified legitimate, integrity-matched, zero new transitive deps).
Fixes applied from review: inlined the robot icon so
currentColorworks in dark mode, neutral-styled the "Soon" badge for AA contrast, added dialog focus management, and documented the search caveat.Verification
npm run buildsucceeds and generatessearch-index.json+ the/searchroute.npm startdev server boots and compiles (exercises the overriddenuuidviasockjs).npm audit→ 0 vulnerabilities.Notes for reviewers
npm run build && npm run serve. The index is not generated undernpm start(documented in the README) — the dev search box opens but returns no results in dev. This is expected plugin behavior.npm installthennpm run clearif you hit a webpackChunkLoadErrorfrom a stale cache/tab.🤖 Generated with Claude Code