This repository was archived by the owner on Jan 19, 2024. It is now read-only.
Fix for compilation error issue5#7
Open
jessesteinen wants to merge 2 commits into
Open
Conversation
…demcuv2/ArduinoJson@6.10.0/src/ArduinoJson/MsgPack/MsgPackSerializer.hpp:28:7: error: attributes are not allowed on a function-definition ), also see https://github.com/bblanchon/ArduinoJson/releases/tag/v6.10.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is to resolve issue #5 on the tracker, caused by an outdated ArduinoJson library (6.10.0). Although the current 6.18.0 version of that library seems to work well here, I've updated minimally to 6.10.1, where this bug was resolved by the library maintainer, to avoid any unforeseen issues.
As a bonus I've updated .gitignore to include .DS_Store system file on macOS and also lib/Device/Device.h as that should always be user-specific.
Hope this helps a bit!