Skip to content

The Open Graph standard allows for additional metadata to be supplied… #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamesapyrich wants to merge 2 commits into
base: master
Choose a base branch
from
Open

The Open Graph standard allows for additional metadata to be supplied… #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
360aaec
The Open Graph standard allows for additional metadata to be supplied…
jamesapyrich Jun 24, 2019
b60eb8b
Merge branch 'master' into og-image-too-greedy
jamesapyrich Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/link_preview/parsers/opengraph.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ defmodule LinkPreview.Parsers.Opengraph do
images =
body
|> Floki.parse()
|> Floki.find("meta[property^=\"og:image\"]")
|> Floki.find("meta[property=\"og:image\"]")
|> Floki.attribute("content")
|> Enum.map(&String.trim(&1))
|> maybe_force_absolute_url(page)
Expand Down
8 changes: 7 additions & 1 deletion test/support/fixtures/opengraph_example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,15 @@
<meta property="og:description" content="Opengraph Test Description">
<meta property="og:image" content="http://example.com/images/og1.jpg ">
<meta property="og:image" content="http://example.com/images/og2.jpg">
<meta property="og:image:url" content="http://example.com/images/og2.jpg">
<meta property="og:image:secure_url" content="https://example.com/images/og2.jpg">
<meta property="og:image:type" content="image/jpeg">
<meta property="og:image:width" content="800">
<meta property="og:image:height" content="600">
<meta property="og:image:alt" content="A test image for OpenGraph">

<meta property="og:title" content="Second?!">
<meta property="og:description" content="Second?!">
</head>
<body></body>
</html>
</html>