Skip to content

feat: robust http streaming #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loks0n wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: robust http streaming #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
159 changes: 13 additions & 146 deletions src/KubernetesCluster.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ class KubernetesCluster
use Traits\Cluster\ChecksClusterVersion;
use Traits\Cluster\LoadsFromKubeConfig;
use Traits\Cluster\MakesHttpCalls;
use Traits\Cluster\MakesWatchCalls;
use Traits\Cluster\MakesWebsocketCalls;

/**
Expand Down Expand Up @@ -176,8 +177,8 @@ public function runOperation(Operation|string $operation, string $path, string|n
}

return match ($operation) {
Operation::WATCH => $this->watchPath($path, $payload, $query),
Operation::WATCH_LOGS => $this->watchLogsPath($path, $payload, $query),
Operation::WATCH => $this->runWatchOperation($this->watchPath($path, $payload, $query)),
Operation::WATCH_LOGS => $this->runWatchOperation($this->watchLogsPath($path, $payload, $query)),
Operation::EXEC => $this->execPath($path, $query),
Operation::ATTACH => $this->attachPath($path, $payload, $query),
Operation::APPLY => $this->applyPath($path, $payload, $query),
Expand All @@ -188,156 +189,22 @@ public function runOperation(Operation|string $operation, string $path, string|n
}

/**
* Watch for the current resource or a resource list.
* Run a watch operation and return the result.
*
* @return mixed|null
* @param array{0: \React\EventLoop\LoopInterface, 1: \React\Promise\PromiseInterface} $loopAndPromise
*/
protected function watchPath(string $path, Closure $callback, array $query = ['pretty' => 1]): mixed
protected function runWatchOperation(array $loopAndPromise): mixed
{
$resourceClass = $this->resourceClass;
$sock = $this->createSocketConnection($this->getCallableUrl($path, $query));
[$loop, $promise] = $loopAndPromise;

if ($sock === false) {
return null;
}

// Set stream to non-blocking mode to allow timeout handling
stream_set_blocking($sock, false);

// Calculate overall timeout: server timeout + buffer for network/processing
$timeout = ($query['timeoutSeconds'] ?? 30) + 5;
$endTime = time() + $timeout;

$buffer = '';

while (time() < $endTime) {
// Try to read data (non-blocking)
$chunk = fread($sock, 8192);

if ($chunk === false) {
// Error occurred
fclose($sock);

return null;
}

if ($chunk === '') {
// No data available, check if stream ended
if (feof($sock)) {
break;
}

// No data yet, sleep briefly and continue
usleep(100000); // 100ms

continue;
}

// Append chunk to buffer
$buffer .= $chunk;

// Process complete lines from buffer
while (($pos = strpos($buffer, "\n")) !== false) {
$line = substr($buffer, 0, $pos);
$buffer = substr($buffer, $pos + 1);

if (trim($line) === '') {
continue;
}

$data = @json_decode($line, true);

if (! $data || ! isset($data['type'], $data['object'])) {
continue;
}

['type' => $type, 'object' => $attributes] = $data;

$call = call_user_func(
$callback,
$type,
new $resourceClass($this, $attributes)
);

if (! is_null($call)) {
fclose($sock);

return $call;
}
}
}

fclose($sock);

return null;
}

/**
* Watch for the logs for the resource.
*
* @return mixed|null
*/
protected function watchLogsPath(string $path, Closure $callback, array $query = ['pretty' => 1]): mixed
{
$sock = $this->createSocketConnection($this->getCallableUrl($path, $query));

if ($sock === false) {
return null;
}

// Set stream to non-blocking mode to allow timeout handling
stream_set_blocking($sock, false);

// Calculate overall timeout: server timeout + buffer for network/processing
$timeout = ($query['timeoutSeconds'] ?? 30) + 5;
$endTime = time() + $timeout;

$buffer = '';

while (time() < $endTime) {
// Try to read data (non-blocking)
$chunk = fread($sock, 8192);

if ($chunk === false) {
// Error occurred
fclose($sock);

return null;
}

if ($chunk === '') {
// No data available, check if stream ended
if (feof($sock)) {
break;
}

// No data yet, sleep briefly and continue
usleep(100000); // 100ms

continue;
}

// Append chunk to buffer
$buffer .= $chunk;

// Process complete lines from buffer
while (($pos = strpos($buffer, "\n")) !== false) {
$line = substr($buffer, 0, $pos);
$buffer = substr($buffer, $pos + 1);

$call = call_user_func($callback, $line."\n");

if (! is_null($call)) {
fclose($sock);

return $call;
}
}
}
$result = null;
$promise->then(function ($value) use (&$result) {
$result = $value;
});

fclose($sock);
$loop->run();

return null;
return $result;
}

/**
Expand Down
Loading