fix: FPV camera points wrong way when loading a Parthenon URL until you move the mouse#30
Merged
Merged
Conversation
…w points correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading the Parthenon example with an FPV state baked into the URL hash (e.g.
#0IBnSyixT9S_t5EGyOput2M) rendered the camera looking in the wrong direction until you moved the mouse. Happened in both matrix and marble styles — FPV only.Cause:
applyStaterestored the FPV origin before the look angles.fpv.setOrigin()callssyncTarget(), which derivescamera.targetfrom the currentrotX/rotY— so it baked the default look into the target, and the restoredrotX/rotYset afterwards never re-synced the target. A mouse-move fired the mouselook handler, which re-ransyncTarget()and corrected it.Fix: set the restored
rotX/rotYfirst, then callsetOrigin(), so the target is derived from the restored look.Verified: loading the URL with no mouse-move, the camera target azimuth matches the restored yaw.