fix: close popover when switch menu is cancelled#26
Merged
aqua5230 merged 1 commit intoJun 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a menu bar UI edge case where opening the Switch Panel menu and dismissing it without choosing an item can leave the popover visible but no longer dismissible normally.
The switch menu is shown with a modal NSMenu. When that menu is cancelled, we now close the still-visible popover instead of trying to keep it alive in a broken transient state. Menu item actions mark that an action was taken, so normal panel selection and settings toggles keep their existing behavior.
Test plan
.venv/bin/ruff check menubar.py tests/test_menubar.py.venv/bin/mypy menubar.py tests/test_menubar.py.venv/bin/python -m pytest tests/test_menubar.py -qNotes for reviewer
This intentionally closes the popover only when the switch menu is dismissed without selecting anything. That avoids the previous stuck popover state without adding a close/reopen flash after the menu closes.