ACL: optimize checkOracle()#500
Open
sohkai wants to merge 3 commits into
Open
Conversation
izqui
approved these changes
Mar 27, 2019
| 0x20 // uint256 return | ||
| ) | ||
|
|
||
| if gt(success, 0) { |
Contributor
There was a problem hiding this comment.
Looks like coverage is crashing when instrumenting this line
Contributor
Author
There was a problem hiding this comment.
Ahh shoot, I remember having this issue with SafeERC20 but ended up putting that in the skip list.
facuspagnuolo
approved these changes
Mar 29, 2019
| 0x20 // uint256 return | ||
| ) | ||
|
|
||
| // solidity-coverage fails on assembly `if` |
Co-Authored-By: sohkai <qisheng.brett.sun@gmail.com>
sohkai
force-pushed
the
acl-optimize-check-oracle
branch
from
2047972 to
ea30416
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
ACL's staticcall to use a more-optimized one similar toSafeERC20'sinvokeAndCheckSuccess().Bytecode comparison: