Davis-Chung submission#1
Open
henrichung wants to merge 3 commits into
Open
Conversation
araiho
reviewed
Sep 29, 2017
araiho
left a comment
araiho
left a comment
Owner
There was a problem hiding this comment.
Good job figuring out ordering and unique. There are a few places where naming is inconsistent or non-informative. The last question was not totally complete so for this assignment your grade is 3.5/4.
| wages = read.csv(file="wages.csv", header=TRUE, stringsAsFactors = FALSE) | ||
|
|
||
| #Challenge question 1 | ||
| test1 <- unique(wages[,c("gender","yearsExperience")]) |
Owner
There was a problem hiding this comment.
try to avoid names like 'test1' and 'test2.' It will make your code confusing when you have to come back to it someday.
| #Challenge question 2 | ||
|
|
||
|
|
||
| #Challenge question 3 |
Owner
There was a problem hiding this comment.
The key word in this question is effect. So, the correct answer would include the difference between the minimum difference between graduating high school and graduating college.
| head(sorted.wages, n = 1) | ||
|
|
||
| #Lowest Wage | ||
| tail(sort.wages, n = 1) |
Owner
There was a problem hiding this comment.
I think that you switch names here. This will cause an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Challenges 1 and 3 are in one file. Challenge 2 was done separately.