Skip to content

chore(workspace): promote internal path deps to workspace.dependencies#280

Merged
AprilNEA merged 1 commit intomasterfrom
chore/promote-workspace-deps
Apr 27, 2026
Merged

chore(workspace): promote internal path deps to workspace.dependencies#280
AprilNEA merged 1 commit intomasterfrom
chore/promote-workspace-deps

Conversation

@AprilNEA
Copy link
Copy Markdown
Member

Summary

  • Five workspace members were consumed by other members but path-deped manually instead of going through `[workspace.dependencies]`. As a result `arcbox-net-inject` and `arcbox-fs` were still pinned to `0.4.0` in `arcbox-vmm` while the workspace had moved to `0.4.1`, and future bumps had to be hand-edited per consumer.
  • Promote each one so every cross-member dep flows through the workspace, and fix the stale `arcbox-fs` pin while moving it to `workspace = true`.
Crate Consumer Notes
`arcbox-route` `arcbox-helper`
`arcbox-hv` `arcbox-vmm` kept on its independent `0.3.20` release line
`arcbox-net-inject` `arcbox-vmm` drift fix `0.4.0` → `0.4.1`
`arcbox-migration` `arcbox-core`
`arcbox-oci` (none yet) promoted preemptively for consistency

Also fixes `arcbox-fs` in `arcbox-vmm`: was `{ version = "0.4.0", path = ".." }`, now `{ workspace = true }`.

Test plan

  • `cargo check --workspace` clean
  • `cargo check --workspace --all-features` clean
  • `cargo clippy --workspace --all-targets -- -D warnings` clean
  • `cargo fmt --check` clean

Copilot AI review requested due to automatic review settings April 27, 2026 04:13
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 27, 2026

Greptile Summary

This PR centralizes five internal cross-member Cargo dependencies into [workspace.dependencies], replacing ad-hoc path-only or stale version + path entries in consumer Cargo.toml files. As a side-effect, arcbox-fs and arcbox-net-inject in arcbox-vmm are corrected from the stale 0.4.0 pin to the current 0.4.1, and all future version bumps only need to be made in the root Cargo.toml.

Confidence Score: 5/5

Safe to merge — pure Cargo manifest refactoring with no logic changes and two correct version-drift fixes.

All changes are mechanical: path-only deps promoted to workspace inheritance, stale 0.4.0 pins corrected to 0.4.1, and arcbox-hv's independent 0.3.20 line preserved correctly in the workspace entry. No code logic is touched, and the PR description's test checklist (cargo check, clippy, fmt) confirms the workspace compiles cleanly. No P0/P1 findings.

No files require special attention.

Important Files Changed

Filename Overview
Cargo.toml Adds arcbox-route, arcbox-hv (0.3.20), arcbox-net-inject, arcbox-oci, and arcbox-migration to [workspace.dependencies] with correct versions and paths.
app/arcbox-core/Cargo.toml Migrates arcbox-migration from path-only dep to workspace = true; no version drift involved.
app/arcbox-helper/Cargo.toml Migrates arcbox-route from path-only dep to workspace = true; no version drift involved.
virt/arcbox-vmm/Cargo.toml Migrates arcbox-hv, arcbox-fs, and arcbox-net-inject to workspace = true; fixes stale 0.4.0 pins for arcbox-fs and arcbox-net-inject; arcbox-hv correctly inherits its independent 0.3.20 line.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    WS["[workspace.dependencies]\n(Cargo.toml)"]

    WS -->|"arcbox-route 0.4.1\n(newly promoted)"| AH["arcbox-helper"]
    WS -->|"arcbox-hv 0.3.20\n(newly promoted, independent line)"| AV["arcbox-vmm"]
    WS -->|"arcbox-fs 0.4.1\n(was 0.4.0 — drift fixed)"| AV
    WS -->|"arcbox-net-inject 0.4.1\n(was 0.4.0 — drift fixed)"| AV
    WS -->|"arcbox-migration 0.4.1\n(newly promoted)"| AC["arcbox-core"]
    WS -->|"arcbox-oci 0.4.1\n(preemptive, no consumer yet)"| NONE["(future consumers)"]
Loading

Reviews (2): Last reviewed commit: "chore(workspace): promote internal path ..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Promotes several internal crate dependencies to the workspace-level dependency table so cross-member deps are consistently versioned and don’t drift between consumers (notably fixing stale 0.4.0 pins in arcbox-vmm).

Changes:

  • Added missing internal crates to [workspace.dependencies] (arcbox-route, arcbox-hv, arcbox-net-inject, arcbox-oci, arcbox-migration).
  • Switched member crates from manual path (and stale version) deps to { workspace = true }.
  • Fixed arcbox-vmm’s arcbox-fs / arcbox-net-inject dependency drift (0.4.0 → workspace 0.4.1).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
Cargo.toml Centralizes additional internal crates in [workspace.dependencies] to ensure consistent version/path resolution across the workspace.
virt/arcbox-vmm/Cargo.toml Moves arcbox-hv, arcbox-fs, and arcbox-net-inject to workspace deps, eliminating stale pins.
app/arcbox-helper/Cargo.toml Uses workspace dependency for arcbox-route instead of a direct path dep.
app/arcbox-core/Cargo.toml Uses workspace dependency for arcbox-migration instead of a direct path dep.

Five member libraries were consumed by other members but path-deped
manually instead of going through `[workspace.dependencies]`. That made
their version pinning drift (`arcbox-net-inject` and `arcbox-fs` were
still on `0.4.0` while the workspace had moved to `0.4.1`) and meant
future bumps had to be hand-edited per consumer.

Promote them so every cross-member dep flows through the workspace:

- `arcbox-route`     ← `arcbox-helper`
- `arcbox-hv`        ← `arcbox-vmm` (kept on its independent 0.3.20 release line)
- `arcbox-net-inject`← `arcbox-vmm`
- `arcbox-migration` ← `arcbox-core`
- `arcbox-oci`       (no current consumer — promoted preemptively for consistency)

Also fix the stale `arcbox-fs = "0.4.0"` pin in `arcbox-vmm` while
moving it to `workspace = true`.
@AprilNEA AprilNEA force-pushed the chore/promote-workspace-deps branch from 7b670a3 to 1c1f9db Compare April 27, 2026 04:57
@AprilNEA AprilNEA merged commit cfeffd8 into master Apr 27, 2026
9 checks passed
@AprilNEA AprilNEA deleted the chore/promote-workspace-deps branch April 27, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants