chore(workspace): promote internal path deps to workspace.dependencies#280
chore(workspace): promote internal path deps to workspace.dependencies#280
Conversation
Greptile SummaryThis PR centralizes five internal cross-member Cargo dependencies into Confidence Score: 5/5Safe to merge — pure Cargo manifest refactoring with no logic changes and two correct version-drift fixes. All changes are mechanical: path-only deps promoted to workspace inheritance, stale 0.4.0 pins corrected to 0.4.1, and arcbox-hv's independent 0.3.20 line preserved correctly in the workspace entry. No code logic is touched, and the PR description's test checklist (cargo check, clippy, fmt) confirms the workspace compiles cleanly. No P0/P1 findings. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
WS["[workspace.dependencies]\n(Cargo.toml)"]
WS -->|"arcbox-route 0.4.1\n(newly promoted)"| AH["arcbox-helper"]
WS -->|"arcbox-hv 0.3.20\n(newly promoted, independent line)"| AV["arcbox-vmm"]
WS -->|"arcbox-fs 0.4.1\n(was 0.4.0 — drift fixed)"| AV
WS -->|"arcbox-net-inject 0.4.1\n(was 0.4.0 — drift fixed)"| AV
WS -->|"arcbox-migration 0.4.1\n(newly promoted)"| AC["arcbox-core"]
WS -->|"arcbox-oci 0.4.1\n(preemptive, no consumer yet)"| NONE["(future consumers)"]
Reviews (2): Last reviewed commit: "chore(workspace): promote internal path ..." | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
Promotes several internal crate dependencies to the workspace-level dependency table so cross-member deps are consistently versioned and don’t drift between consumers (notably fixing stale 0.4.0 pins in arcbox-vmm).
Changes:
- Added missing internal crates to
[workspace.dependencies](arcbox-route,arcbox-hv,arcbox-net-inject,arcbox-oci,arcbox-migration). - Switched member crates from manual
path(and staleversion) deps to{ workspace = true }. - Fixed
arcbox-vmm’sarcbox-fs/arcbox-net-injectdependency drift (0.4.0→ workspace0.4.1).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Cargo.toml |
Centralizes additional internal crates in [workspace.dependencies] to ensure consistent version/path resolution across the workspace. |
virt/arcbox-vmm/Cargo.toml |
Moves arcbox-hv, arcbox-fs, and arcbox-net-inject to workspace deps, eliminating stale pins. |
app/arcbox-helper/Cargo.toml |
Uses workspace dependency for arcbox-route instead of a direct path dep. |
app/arcbox-core/Cargo.toml |
Uses workspace dependency for arcbox-migration instead of a direct path dep. |
Five member libraries were consumed by other members but path-deped manually instead of going through `[workspace.dependencies]`. That made their version pinning drift (`arcbox-net-inject` and `arcbox-fs` were still on `0.4.0` while the workspace had moved to `0.4.1`) and meant future bumps had to be hand-edited per consumer. Promote them so every cross-member dep flows through the workspace: - `arcbox-route` ← `arcbox-helper` - `arcbox-hv` ← `arcbox-vmm` (kept on its independent 0.3.20 release line) - `arcbox-net-inject`← `arcbox-vmm` - `arcbox-migration` ← `arcbox-core` - `arcbox-oci` (no current consumer — promoted preemptively for consistency) Also fix the stale `arcbox-fs = "0.4.0"` pin in `arcbox-vmm` while moving it to `workspace = true`.
7b670a3 to
1c1f9db
Compare
Summary
Also fixes `arcbox-fs` in `arcbox-vmm`: was `{ version = "0.4.0", path = ".." }`, now `{ workspace = true }`.
Test plan