Skip to content

fix: resolve symlinks before calculating relative dependency paths #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lilydjwg merged 1 commit into from
May 9, 2026
Merged

fix: resolve symlinks before calculating relative dependency paths #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lilac2/building.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,9 @@ def resolve_depends(repo: Optional[Repo], depends: Iterable[Dependency]) -> list
continue
need_build_first.add(x.pkgname)
else:
depend_packages.append(f'../{p.relative_to(cwd)}')
# cwd is a physical path, resolve symlinks to prevent relative_to() error
p_real = p.resolve()
depend_packages.append(f'../{p_real.relative_to(cwd)}')

if need_build_first:
raise MissingDependencies(need_build_first)
Expand Down
Loading