fix(api): trust APP_BASE_URL for CSRF origin checks#49
Merged
Conversation
CSRF origin checks should use APP_BASE_URL as the canonical public URL even when CORS_ORIGINS is explicitly configured. This avoids relying on proxy forwarded headers while preserving the explicit CORS origin allow-list. Made-with: Cursor
|
🚅 Deployed to the archmax-pr-49 environment in archmax SemLayer
|
railway-app
Bot
temporarily deployed
to
archmax SemLayer / archmax-pr-49
Docker image readydocker pull ghcr.io/archmaxai/archmax:pr-49 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
APP_BASE_URLdirectly during CSRF origin checks, even whenCORS_ORIGINSis explicitly configured.CORS_ORIGINSas the explicit additional origin allow-list.Test plan
pnpm exec vitest run apps/api/src/middleware/csrf.test.ts— 11/11 passAPP_BASE_URLset to the public origin.Made with Cursor