[server] remove deprecated handleNodeRequest

[EmrysMyrddin]

Description

Remove the deprecated handleNodeRequest in favor of handleNodeRequestAndResponse.

Type of change

Please delete options that are not relevant.

• Breaking change (fix or feature that would cause existing functionality to not work as
  expected)

[github-actions]

✅ @benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=138.840959 min=103    med=138     max=199      p(90)=161     p(95)=165    
     data_received..................: 21 MB  714 kB/s
     data_sent......................: 14 MB  462 kB/s
     http_req_blocked...............: avg=4.15µs     min=621ns  med=1.37µs  max=10.36ms  p(90)=2.03µs  p(95)=2.31µs 
     http_req_connecting............: avg=2.18µs     min=0s     med=0s      max=5.89ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=21.37ms    min=2.92ms med=20.8ms  max=261.43ms p(90)=27.3ms  p(95)=29.88ms
       { expected_response:true }...: avg=21.37ms    min=2.92ms med=20.8ms  max=261.43ms p(90)=27.3ms  p(95)=29.88ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 139921
     http_req_receiving.............: avg=36.39µs    min=9.13µs med=24.51µs max=37.53ms  p(90)=39.76µs p(95)=47.14µs
     http_req_sending...............: avg=11.55µs    min=3.29µs med=6.73µs  max=38.16ms  p(90)=9.99µs  p(95)=14.03µs
     http_req_tls_handshaking.......: avg=0s         min=0s     med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=21.32ms    min=2.78ms med=20.77ms max=261.26ms p(90)=27.25ms p(95)=29.79ms
     http_reqs......................: 139921 4663.644288/s
     iteration_duration.............: avg=42.85ms    min=8.93ms med=41.33ms max=292.74ms p(90)=48.97ms p(95)=54.32ms
     iterations.....................: 69919  2330.438926/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

[github-actions]

✅ @benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=139.173551 min=53       med=139     max=200      p(90)=160     p(95)=165    
     data_received..................: 21 MB  692 kB/s
     data_sent......................: 13 MB  444 kB/s
     http_req_blocked...............: avg=4.21µs     min=611ns    med=1.25µs  max=11.61ms  p(90)=2.01µs  p(95)=2.23µs 
     http_req_connecting............: avg=2µs        min=0s       med=0s      max=6.97ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=22.02ms    min=956.26µs med=21.44ms max=880.81ms p(90)=27.91ms p(95)=30.05ms
       { expected_response:true }...: avg=22.02ms    min=956.26µs med=21.44ms max=880.81ms p(90)=27.91ms p(95)=30.05ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 135761
     http_req_receiving.............: avg=34.42µs    min=9.42µs   med=24.36µs max=21.55ms  p(90)=38.69µs p(95)=44.46µs
     http_req_sending...............: avg=10.54µs    min=3.39µs   med=6.06µs  max=28.36ms  p(90)=9.7µs   p(95)=13.03µs
     http_req_tls_handshaking.......: avg=0s         min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=21.98ms    min=922.66µs med=21.4ms  max=880.73ms p(90)=27.86ms p(95)=29.98ms
     http_reqs......................: 135761 4524.920329/s
     iteration_duration.............: avg=44.16ms    min=19.15ms  med=42.79ms max=911.23ms p(90)=47.99ms p(95)=54.56ms
     iterations.....................: 67859  2261.743569/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

[github-actions]

✅ @benchmarks/server results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 302058      ✗ 0     
     data_received..................: 30 MB   992 kB/s
     data_sent......................: 12 MB   403 kB/s
     http_req_blocked...............: avg=1.36µs   min=872ns   med=1.17µs   max=209.63µs p(90)=1.84µs   p(95)=1.99µs  
     http_req_connecting............: avg=0ns      min=0s      med=0s       max=134.6µs  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=137.4µs  min=91.82µs med=132.45µs max=9.09ms   p(90)=154.4µs  p(95)=161.55µs
       { expected_response:true }...: avg=137.4µs  min=91.82µs med=132.45µs max=9.09ms   p(90)=154.4µs  p(95)=161.55µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 151029
     http_req_receiving.............: avg=24.52µs  min=12.14µs med=23.44µs  max=1.06ms   p(90)=30.29µs  p(95)=32.56µs 
     http_req_sending...............: avg=6.14µs   min=4µs     med=5.37µs   max=331.58µs p(90)=7.98µs   p(95)=8.51µs  
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=106.73µs min=64.34µs med=101.28µs max=8.87ms   p(90)=120.34µs p(95)=125.99µs
     http_reqs......................: 151029  5034.122139/s
     iteration_duration.............: avg=194.23µs min=137.8µs med=188.22µs max=9.48ms   p(90)=213.51µs p(95)=223.56µs
     iterations.....................: 151029  5034.122139/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

[github-actions]

✅ @benchmarks/server results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 229018      ✗ 0     
     data_received..................: 23 MB   767 kB/s
     data_sent......................: 9.2 MB  305 kB/s
     http_req_blocked...............: avg=1.42µs   min=892ns    med=1.22µs   max=171.37µs p(90)=1.9µs    p(95)=2.07µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=125.09µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=199.81µs min=153.99µs med=186.91µs max=14.31ms  p(90)=213.7µs  p(95)=223.43µs
       { expected_response:true }...: avg=199.81µs min=153.99µs med=186.91µs max=14.31ms  p(90)=213.7µs  p(95)=223.43µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 114509
     http_req_receiving.............: avg=25.84µs  min=14.42µs  med=24.27µs  max=6.38ms   p(90)=31.45µs  p(95)=33.6µs  
     http_req_sending...............: avg=6.27µs   min=4.11µs   med=5.51µs   max=353.18µs p(90)=8.12µs   p(95)=8.64µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=167.69µs min=125.76µs med=154.67µs max=14.22ms  p(90)=177.83µs p(95)=186.56µs
     http_reqs......................: 114509  3816.827377/s
     iteration_duration.............: avg=257.59µs min=206.49µs med=244.06µs max=14.44ms  p(90)=274.3µs  p(95)=287.16µs
     iterations.....................: 114509  3816.827377/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

[github-actions]

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
@whatwg-node/server	0.10.0-alpha-20240726141316-c6ce93b3598457ebe73b3b725986723af8f5e609	npm ↗︎ unpkg ↗︎
@whatwg-node/server-plugin-cookies	2.0.0-alpha-20240726141316-c6ce93b3598457ebe73b3b725986723af8f5e609	npm ↗︎ unpkg ↗︎

[dotansimha]

@EmrysMyrddin no longer relevant?

[ardatan]

@dotansimha It is still relevant. We are keeping this because we don't want to introduce breaking changes on Yoga etc.