Upcoming Release Changes by github-actions[bot] · Pull Request #2406 · ardatan/whatwg-node

github-actions · 2025-05-09T16:11:50Z

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@whatwg-node/fetch@0.10.7

Patch Changes

#2383
9527e8f
Thanks @ardatan! - Some implementations like compression npm
package do not implement response.write(data, callback) signature, but whatwg-node/server waits
for it to finish the response stream. Then it causes the response stream hangs when the
compression package takes the stream over when the response data is larger than its threshold.

It is actually a bug in compression package;
expressjs/compression#46 But since it is a
common mistake, we prefer to workaround this on our end.

Now after calling response.write, it no longer uses callback but first it checks the result;

if it is true, it means stream is drained and we can call response.end immediately. else if it
is false, it means the stream is not drained yet, so we can wait for the drain event to call
response.end.
Updated dependencies
[9527e8f]:
- @whatwg-node/node-fetch@0.7.19

@whatwg-node/node-fetch@0.7.19

Patch Changes

#2383
9527e8f
Thanks @ardatan! - Some implementations like compression npm
package do not implement response.write(data, callback) signature, but whatwg-node/server waits
for it to finish the response stream. Then it causes the response stream hangs when the
compression package takes the stream over when the response data is larger than its threshold.

It is actually a bug in compression package;
expressjs/compression#46 But since it is a
common mistake, we prefer to workaround this on our end.

Now after calling response.write, it no longer uses callback but first it checks the result;

if it is true, it means stream is drained and we can call response.end immediately. else if it
is false, it means the stream is not drained yet, so we can wait for the drain event to call
response.end.
Updated dependencies
[d86b4f3]:
- @whatwg-node/promise-helpers@1.3.2

@whatwg-node/promise-helpers@1.3.2

Patch Changes

#2408
d86b4f3
Thanks @slagiewka! - Reuse fake promise Symbol

@whatwg-node/server@0.10.6

Patch Changes

#2383
9527e8f
Thanks @ardatan! - Some implementations like compression npm
package do not implement response.write(data, callback) signature, but whatwg-node/server waits
for it to finish the response stream. Then it causes the response stream hangs when the
compression package takes the stream over when the response data is larger than its threshold.

It is actually a bug in compression package;
expressjs/compression#46 But since it is a
common mistake, we prefer to workaround this on our end.

Now after calling response.write, it no longer uses callback but first it checks the result;

if it is true, it means stream is drained and we can call response.end immediately. else if it
is false, it means the stream is not drained yet, so we can wait for the drain event to call
response.end.
Updated dependencies
[d86b4f3,
9527e8f]:
- @whatwg-node/promise-helpers@1.3.2
- @whatwg-node/fetch@0.10.7

@benchmarks/server@0.0.53

Patch Changes

Updated dependencies
[9527e8f]:
- @whatwg-node/server@0.10.6

@e2e/aws-lambda@0.0.41

Patch Changes

Updated dependencies
[9527e8f]:
- @whatwg-node/fetch@0.10.7

@e2e/shared-server@0.0.142

Patch Changes

Updated dependencies
[9527e8f]:
- @whatwg-node/fetch@0.10.7
- @whatwg-node/server@0.10.6

@e2e/vercel@0.0.142

Patch Changes

Updated dependencies []:
- @e2e/shared-server@0.0.142

coderabbitai · 2025-05-09T16:11:56Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-05-10T14:56:14Z

✅ `@benchmarks/node-fetch` results (consumeBody)

   ✓ active_handles.................: avg=140.402314 min=13      med=141     max=181     p(90)=158     p(95)=163    
     data_received..................: 20 MB  668 kB/s
     data_sent......................: 13 MB  429 kB/s
     http_req_blocked...............: avg=2.23µs     min=651ns   med=1.23µs  max=3.21ms  p(90)=2.02µs  p(95)=2.25µs 
     http_req_connecting............: avg=532ns      min=0s      med=0s      max=2.8ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=22.82ms    min=2.45ms  med=22.39ms max=1.02s   p(90)=28.51ms p(95)=30.01ms
       { expected_response:true }...: avg=22.82ms    min=2.45ms  med=22.39ms max=1.02s   p(90)=28.51ms p(95)=30.01ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 131077
     http_req_receiving.............: avg=33.55µs    min=9.56µs  med=23.79µs max=19.94ms p(90)=37.47µs p(95)=43.4µs 
     http_req_sending...............: avg=10.5µs     min=3.38µs  med=5.9µs   max=16.39ms p(90)=9.63µs  p(95)=13.02µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=22.77ms    min=2.41ms  med=22.35ms max=1.02s   p(90)=28.47ms p(95)=29.95ms
     http_reqs......................: 131077 4368.783882/s
     iteration_duration.............: avg=45.74ms    min=10.17ms med=44.24ms max=1.05s   p(90)=49.42ms p(95)=54.78ms
     iterations.....................: 65521  2183.808668/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100

github-actions · 2025-05-10T14:56:18Z

✅ `@benchmarks/node-fetch` results (noConsumeBody)

   ✓ active_handles.................: avg=140.380733 min=34      med=139     max=184     p(90)=162     p(95)=165    
     data_received..................: 21 MB  704 kB/s
     data_sent......................: 14 MB  456 kB/s
     http_req_blocked...............: avg=5.3µs      min=651ns   med=1.4µs   max=16.32ms p(90)=2.04µs  p(95)=2.31µs 
     http_req_connecting............: avg=3.35µs     min=0s      med=0s      max=8.26ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=21.66ms    min=4.53ms  med=21.07ms max=1s      p(90)=27.21ms p(95)=28.66ms
       { expected_response:true }...: avg=21.66ms    min=4.53ms  med=21.07ms max=1s      p(90)=27.21ms p(95)=28.66ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 138013
     http_req_receiving.............: avg=33.49µs    min=9.11µs  med=23.89µs max=12.99ms p(90)=38.72µs p(95)=45.02µs
     http_req_sending...............: avg=10.96µs    min=3.32µs  med=6.54µs  max=15.88ms p(90)=9.88µs  p(95)=14.16µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=21.62ms    min=4.35ms  med=21.04ms max=1s      p(90)=27.16ms p(95)=28.6ms 
     http_reqs......................: 138013 4599.653821/s
     iteration_duration.............: avg=43.44ms    min=21.52ms med=41.84ms max=1.03s   p(90)=47.18ms p(95)=53.24ms
     iterations.....................: 68988  2299.210348/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100

github-actions · 2025-05-10T14:56:22Z

✅ `@benchmarks/server` results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 298572      ✗ 0     
     data_received..................: 29 MB   980 kB/s
     data_sent......................: 12 MB   398 kB/s
     http_req_blocked...............: avg=1.4µs    min=942ns    med=1.2µs    max=248.34µs p(90)=1.85µs   p(95)=2.01µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=105.89µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=138.74µs min=93.81µs  med=133.78µs max=5.91ms   p(90)=157.4µs  p(95)=164.67µs
       { expected_response:true }...: avg=138.74µs min=93.81µs  med=133.78µs max=5.91ms   p(90)=157.4µs  p(95)=164.67µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 149286
     http_req_receiving.............: avg=24.42µs  min=12.39µs  med=22.65µs  max=3.85ms   p(90)=30.19µs  p(95)=32.85µs 
     http_req_sending...............: avg=6.17µs   min=4.1µs    med=5.31µs   max=419.56µs p(90)=7.93µs   p(95)=8.52µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=108.15µs min=66.49µs  med=103.13µs max=5.88ms   p(90)=122.95µs p(95)=128.98µs
     http_reqs......................: 149286  4975.996507/s
     iteration_duration.............: avg=196.56µs min=140.76µs med=191.2µs  max=5.99ms   p(90)=217.48µs p(95)=226.8µs 
     iterations.....................: 149286  4975.996507/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1

github-actions · 2025-05-10T14:56:25Z

✅ `@benchmarks/server` results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 216314      ✗ 0     
     data_received..................: 22 MB   725 kB/s
     data_sent......................: 8.7 MB  288 kB/s
     http_req_blocked...............: avg=1.42µs   min=891ns    med=1.21µs   max=272.55µs p(90)=1.91µs   p(95)=2.08µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=140.01µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=213.83µs min=163.24µs med=201.62µs max=50.65ms  p(90)=228.21µs p(95)=237.74µs
       { expected_response:true }...: avg=213.83µs min=163.24µs med=201.62µs max=50.65ms  p(90)=228.21µs p(95)=237.74µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 108157
     http_req_receiving.............: avg=25.88µs  min=14.01µs  med=23.77µs  max=6.14ms   p(90)=31.43µs  p(95)=34.08µs 
     http_req_sending...............: avg=6.43µs   min=4.08µs   med=5.63µs   max=280.71µs p(90)=8.21µs   p(95)=8.95µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=181.51µs min=134.98µs med=169.6µs  max=50.58ms  p(90)=192.43µs p(95)=200.9µs 
     http_reqs......................: 108157  3605.114946/s
     iteration_duration.............: avg=272.78µs min=209.28µs med=259.44µs max=50.77ms  p(90)=289.7µs  p(95)=301.55µs
     iterations.....................: 108157  3605.114946/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1

github-actions · 2025-05-10T14:56:27Z

✅ `@benchmarks/server` results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 232286     ✗ 0     
     data_received..................: 23 MB   778 kB/s
     data_sent......................: 9.3 MB  310 kB/s
     http_req_blocked...............: avg=1.42µs   min=921ns    med=1.19µs   max=1.17ms   p(90)=1.89µs   p(95)=2.05µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=120.53µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=194.93µs min=143.36µs med=184.28µs max=21.69ms  p(90)=211.1µs  p(95)=220.86µs
       { expected_response:true }...: avg=194.93µs min=143.36µs med=184.28µs max=21.69ms  p(90)=211.1µs  p(95)=220.86µs
     http_req_failed................: 0.00%   ✓ 0          ✗ 116143
     http_req_receiving.............: avg=25.31µs  min=14.04µs  med=22.99µs  max=2.7ms    p(90)=30.79µs  p(95)=33.71µs 
     http_req_sending...............: avg=6.3µs    min=4.17µs   med=5.46µs   max=308.14µs p(90)=8.07µs   p(95)=8.81µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=163.3µs  min=112.14µs med=152.7µs  max=21.63ms  p(90)=176.26µs p(95)=185.19µs
     http_reqs......................: 116143  3871.29536/s
     iteration_duration.............: avg=253.83µs min=189.45µs med=242.45µs max=21.81ms  p(90)=272.25µs p(95)=284.46µs
     iterations.....................: 116143  3871.29536/s
     vus............................: 1       min=1        max=1   
     vus_max........................: 1       min=1        max=1

github-actions Bot force-pushed the changeset-release/master branch from 6aec55f to 401e3bb Compare May 9, 2025 16:11

github-actions Bot force-pushed the changeset-release/master branch from 401e3bb to e45099c Compare May 10, 2025 00:29

chore(release): update monorepo packages versions

d03a751

github-actions Bot force-pushed the changeset-release/master branch from e45099c to d03a751 Compare May 10, 2025 12:42

ardatan merged commit 65780bc into master May 10, 2025

ardatan deleted the changeset-release/master branch May 12, 2025 16:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upcoming Release Changes#2406

Upcoming Release Changes#2406
ardatan merged 1 commit into
masterfrom
changeset-release/master

github-actions Bot commented May 9, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 9, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions Bot commented May 10, 2025

Uh oh!

github-actions Bot commented May 10, 2025

Uh oh!

github-actions Bot commented May 10, 2025

Uh oh!

github-actions Bot commented May 10, 2025

Uh oh!

github-actions Bot commented May 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

github-actions Bot commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Releases

@whatwg-node/fetch@0.10.7

Patch Changes

@whatwg-node/node-fetch@0.7.19

Patch Changes

@whatwg-node/promise-helpers@1.3.2

Patch Changes

@whatwg-node/server@0.10.6

Patch Changes

@benchmarks/server@0.0.53

Patch Changes

@e2e/aws-lambda@0.0.41

Patch Changes

@e2e/shared-server@0.0.142

Patch Changes

@e2e/vercel@0.0.142

Patch Changes

Uh oh!

coderabbitai Bot commented May 9, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions Bot commented May 10, 2025

✅ @benchmarks/node-fetch results (consumeBody)

Uh oh!

github-actions Bot commented May 10, 2025

✅ @benchmarks/node-fetch results (noConsumeBody)

Uh oh!

github-actions Bot commented May 10, 2025

✅ @benchmarks/server results (ponyfill)

Uh oh!

github-actions Bot commented May 10, 2025

✅ @benchmarks/server results (undici)

Uh oh!

github-actions Bot commented May 10, 2025

✅ @benchmarks/server results (native)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented May 9, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

✅ `@benchmarks/node-fetch` results (consumeBody)

✅ `@benchmarks/node-fetch` results (noConsumeBody)

✅ `@benchmarks/server` results (ponyfill)

✅ `@benchmarks/server` results (undici)

✅ `@benchmarks/server` results (native)